Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WC Compatibility] Deprecation notices since WooCommerce 9.3 related to the Navigation feature #683

Closed
mattallan opened this issue Sep 16, 2024 · 1 comment
Assignees
Labels
type: bug The issue is a confirmed bug.

Comments

@mattallan
Copy link
Contributor

mattallan commented Sep 16, 2024

WooCommerce 9.3 shipped on September 13th which has deprecated the Navigation\Menu::add_plugin_item and Navigation\Screen::register_post_type functions with no alternative. These functions will be removed in 9.4 which is scheduled for next month.

These function are within class_exists checks so there won't be any fatals when they're removed, however we should still clean up this code.

Full deprecation notice:

[16-Sep-2024 06:05:32 UTC] Automattic\WooCommerce\Admin\Features\Navigation\Menu::add_plugin_item is deprecated since 9.3 with no alternative. Navigation classes will be removed in WooCommerce 9.4
[16-Sep-2024 06:05:32 UTC] Automattic\WooCommerce\Admin\Features\Navigation\Screen::register_post_type is deprecated since 9.3 with no alternative. Navigation classes will be removed in WooCommerce 9.4

These functions were added for Subscriptions support with the new WooCommerce navigation feature that was being worked on:

image

This is no longer the direction WooCommerce is going in and so they're removing all of the Navigation related code from the plugin. See: woocommerce/woocommerce#48997

To Reproduce

  1. Install the latest WooCommerce version along with WooCommerce Subscriptions
  2. Load any admin page
  3. Open debug log to see deprecation warnings.
@mattallan mattallan added the type: bug The issue is a confirmed bug. label Sep 16, 2024
@mattallan mattallan self-assigned this Sep 16, 2024
@mattallan mattallan changed the title [WC Compatibility] Menu::add_plugin_item is deprecated since 9.3 with no alternative. [WC Compatibility] Deprecation notices since WooCommerce 9.3 related to the Navigation feature Sep 16, 2024
@mattallan
Copy link
Contributor Author

Duplicate of #674. Closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug The issue is a confirmed bug.
Projects
None yet
Development

No branches or pull requests

1 participant