Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purchases: It is possible to delete a site with active subscriptions #1192

Closed
scruffian opened this issue Dec 2, 2015 · 2 comments
Closed
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@scruffian
Copy link
Member

When a user deletes a site we should remove the purchases that are associated with it. Right now we prevent users from deleting a site when there are purchases on it, but there are ways to circumvent this in the API, which could leave users in a strange state.

@scruffian scruffian added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. labels Dec 2, 2015
@scruffian scruffian added this to the Purchases: v1 milestone Dec 2, 2015
@drewblaisdell
Copy link
Contributor

Unless we plan on changing the site deletion UX, I think we should just fix the error that allows users to delete a site with active subscriptions. One reason for this is that we can't simply delete active subscriptions for domain registrations without asking the user explicitly if the want to cancel/transfer (props to @wensco for that clarification).

I'm going to update this issue to track preventing users from deleting a site with active subscriptions, which the current desired behavior in Calypso. I opened a PR for this here: #1246

@drewblaisdell drewblaisdell changed the title Purchases: Deleting a site doesn't remove purchases Purchases: It is possible to delete a site with active subscriptions Dec 3, 2015
@drewblaisdell drewblaisdell added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 3, 2015
@drewblaisdell
Copy link
Contributor

Actually, we have an issue for that already: #1110. I'm going to close this and use the other issue to track. Please reopen if you think that we should change the way site deletion works to make it possible to delete a site with active subscriptions. :)

@drewblaisdell drewblaisdell removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

3 participants