Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help: Use ExternalLink component in search results #1349

Closed
dllh opened this issue Dec 7, 2015 · 1 comment
Closed

Help: Use ExternalLink component in search results #1349

dllh opened this issue Dec 7, 2015 · 1 comment
Assignees
Labels
[Feature Group] Support All things related to WordPress.com customer support. [Status] Stale [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Milestone

Comments

@dllh
Copy link
Member

dllh commented Dec 7, 2015

Repro:

  1. Go to /help
  2. Perform a search.
  3. Observe the results.

They'll look something like this:

screen shot 2015-12-07 at 5 03 36 pm

The results right now link to documents not inside Calypso. Elsewhere it had been suggested that we use <ExternalLink> for external links. It shows the little arrow indicating that the link will go off-site (see e.g. #1229). I imagine we probably need to do the same for these search results.

@dllh dllh added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature Group] Support All things related to WordPress.com customer support. labels Dec 7, 2015
@dllh dllh added this to the Help: v1 milestone Dec 7, 2015
@dllh dllh assigned dllh and omarjackman and unassigned omarjackman and dllh Dec 15, 2015
@dllh dllh modified the milestones: Help: Future, Help: v1 Dec 16, 2015
@stale
Copy link

stale bot commented Jan 12, 2018

This issue has been marked as stale because it hasn't been updated in a while. It will be closed in a week. If you would like it to remain open, can you please comment below and see what you can do to get things moving with this issue? Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Support All things related to WordPress.com customer support. [Status] Stale [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

2 participants