Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plans: Use one file for all variants of plan logos #1469

Closed
stephanethomas opened this issue Dec 10, 2015 · 2 comments
Closed

Plans: Use one file for all variants of plan logos #1469

stephanethomas opened this issue Dec 10, 2015 · 2 comments
Labels
[Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. [Status] Stale [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Milestone
Plans: Maintenance

Comments

@stephanethomas
Copy link
Contributor

We've introduced new variants of the logos of Premium and Business plans in #1395. Right now these are separate files whereas we should most certainly use only one SVG file and use CSS to control how the image should look like. This is important considering the number of variants that will have to be implemented since this will reduce the amount of data to download:
@stephanethomas stephanethomas added [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. Free Trials labels Dec 10, 2015
@stephanethomas stephanethomas added this to the No-cc Free Trials: v1 milestone Dec 10, 2015
@stephanethomas stephanethomas mentioned this issue Dec 10, 2015
Merged
2 tasks
@mikeshelton1503
Copy link
Contributor

This is not official but here is an example of possible variants we may use in the future:

image

@fabianapsimoes fabianapsimoes modified the milestones: No-cc Free Trials: v2, No-cc Free Trials: v1 Dec 11, 2015
@fabianapsimoes fabianapsimoes modified the milestones: No-cc Free Trials: v2, Free Trials: Future Feb 25, 2016
@fabianapsimoes fabianapsimoes added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it and removed [Type] Task labels Mar 15, 2016
@fabianapsimoes fabianapsimoes modified the milestones: Free Trials: Future, Plans: Maintenance Apr 12, 2016
@stale
Copy link

stale bot commented Jan 11, 2018

This issue has been marked as stale because it hasn't been updated in a while. It will be closed in a week. If you would like it to remain open, can you please comment below and see what you can do to get things moving with this issue? Thanks! 🙏

@stale stale bot added the [Status] Stale label Jan 11, 2018
This was referenced Sep 15, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. [Status] Stale [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
Plans: Maintenance
Development

No branches or pull requests
4 participants
@lancewillett @stephanethomas @fabianapsimoes @mikeshelton1503