Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purchases: Certain texts on expired upgrades are hard to read #258

Closed
hafizrahman opened this issue Nov 20, 2015 · 9 comments
Closed

Purchases: Certain texts on expired upgrades are hard to read #258

hafizrahman opened this issue Nov 20, 2015 · 9 comments
Labels
Accessibility (a11y) [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@hafizrahman
Copy link
Member

On https://wordpress.com/purchases:
screen shot 2015-11-20 at 4 50 08 pm

On On https://wordpress.com/purchases/:site/:purchaseId
screen shot 2015-11-20 at 4 50 25 pm

From the CSS it looks like there's an added opacity of 0.6 to these texts. I don't see why it's a good idea to make an expired upgrade's information to be harder to read. An expired upgrade can affect a user's site negatively in various ways. Wouldn't it be better if we present that information clearer?

Here's the WCAG color contrast checker result for the least contrast-y text color on those screenshots: http://webaim.org/resources/contrastchecker/?fcolor=668eaa&bcolor=f3f6f8

Normal Text
WCAG AA: Fail
WCAG AAA: Fail
Large Text
WCAG AA: Pass
WCAG AAA: Fail

@hafizrahman hafizrahman added Upgrades [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. labels Nov 20, 2015
@fabianapsimoes fabianapsimoes added [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. and removed [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. Upgrades labels Nov 20, 2015
@SiobhyB SiobhyB added the Accessibility (a11y) label Nov 20, 2015
@mikeshelton1503
Copy link
Contributor

The reason for the dropped opacity is to focus the user on the red notice which explains to the user the issue and the action to solve it. The intent wasn't necessarily to make the other info hard to read though. We could set the opacity back to 1 for the text, leaving the background color as is.

image

@Lochlaer
Copy link

Adding to this report that the list of upgrades on the /Purchases page has the same problem. Important information like the URL and the type of upgrade that needs renewal is in really low contrast font. I literally had to squint a bit to read it, and my eyesight is in the normal range for my age (mid-forties).

screen_shot_2015-11-21_at_2_28_18_pm

The font styles failed the AA Color Checker Test:

screen shot 2015-11-21 at 2 32 17 pm

@gziolo gziolo added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Nov 24, 2015
@fabianapsimoes
Copy link
Contributor

Pinging @mikeshelton1503 for feedback on Marjorie's findings.

@mikeshelton1503
Copy link
Contributor

So the colors used here are consistent with other areas of Calypso so I think this should be brought up a broader scale. Let's leave this open for now and I'll use it as a basis to start the conversation.

@mikeshelton1503 mikeshelton1503 added the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label Feb 25, 2016
@davewhitley
Copy link
Contributor

Aside — can we make sure that the color Marjorie is referring to is using a color variable? The one she tested is not in our handbook I don't think. Doesn't affect the accessibility though, I just wanted to make sure.

@mikeshelton1503
Copy link
Contributor

can we make sure that the color Marjorie is referring to is using a color variable? The one she tested is not in our handbook I don't think.

Yep it's using gray. The color checker must have just sampled it slightly incorrectly.

@fabianapsimoes
Copy link
Contributor

fabianapsimoes commented Apr 18, 2016

@mikeshelton1503 did anything come out of this issue, or should we call this a won't fix?

@mikeshelton1503
Copy link
Contributor

No nothing has been started in this area AFAIK, however we don't need to keep this one open. Any change here will need a broader effort.

@fabianapsimoes
Copy link
Contributor

Thanks, Mike! I'll close this one then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility (a11y) [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

8 participants