Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenboarding: fix confusing keyboard focus / mouse hover states #39138

Closed
simison opened this issue Jan 29, 2020 · 1 comment · Fixed by #39156
Closed

Gutenboarding: fix confusing keyboard focus / mouse hover states #39138

simison opened this issue Jan 29, 2020 · 1 comment · Fixed by #39156
Assignees
Labels
[Goal] New Onboarding previously called Gutenboarding

Comments

@simison
Copy link
Member

simison commented Jan 29, 2020

When landing at page selector, the first item has "focus" by default and it thus gets focus styles (dark border):

Screenshot 2020-01-29 at 16 17 10

When I now hover with mouse anything else on this page, they also get hover state:

Screenshot 2020-01-29 at 16 17 16

Once I select something, things look good again:

image

I would expect to see the initial focus state be visible only when I'm keyboard navigating. I think we use accessible-focus elsewhere to show keyboard focus only when tabbing with keyboard, but there could be some more simple solution as well.

@simison simison added the [Goal] New Onboarding previously called Gutenboarding label Jan 29, 2020
@Addison-Stavlo
Copy link
Contributor

Addison-Stavlo commented Jan 29, 2020

My apologies if I am stepping on any toes here.

I was looking into #38665 and noticed this lingering-focus problem while I was working on that. I went ahead with trying to fix it before I saw this issue had some folks assigned already. Im going to go ahead and open this small PR for it, but feel free to take it over or make any changes you see fit if desired.

Again, sorry for jumping onto the already assigned issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] New Onboarding previously called Gutenboarding
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants