Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack linked sites are not showing up in some views on Calypso dashboard #57295

Closed
devNigel opened this issue Oct 23, 2021 · 3 comments · Fixed by #57952
Closed

Jetpack linked sites are not showing up in some views on Calypso dashboard #57295

devNigel opened this issue Oct 23, 2021 · 3 comments · Fixed by #57952
Assignees
Labels
Jetpack [Pri] Low Address when resources are available. Sites [Type] Bug When a feature is broken and / or not performing as intended

Comments

@devNigel
Copy link

Quick summary

Jetpack linked sites are not showing up in the list of sites at https://wordpress.com/home

But it is showing up on other views like this:

Steps to reproduce

  1. Create a WPORG site. You can use https://jurassic.ninja/
  2. Connect it to your WordPress.com account.
  3. You can see the site is showing in the list under My Sites and views mentioned about, but not in https://wordpress.com/home

What you expected to happen

I expected sites list to be consistent across all views

What actually happened

The Jetpack sites are missing from https://wordpress.com/home

Context

Chat interaction: 32244628-hc

Operating System

No response

Browser

No response

Simple, Atomic or both?

No response

Theme-specific issue?

No response

Other notes

No response

Reproducibility

Consistent

Severity

All

Available workarounds?

Yes, easy to implement

Workaround details

Users will have to check under My Sites or other views.

@devNigel devNigel added [Type] Bug When a feature is broken and / or not performing as intended User Report labels Oct 23, 2021
@dpasque
Copy link
Contributor

dpasque commented Oct 28, 2021

Switching over to @Automattic/flow-patrol-create for the time being because it seems to be affecting the My Home page.

@dpasque dpasque added the [Pri] Low Address when resources are available. label Oct 28, 2021
@ivan-ottinger ivan-ottinger self-assigned this Nov 10, 2021
@ivan-ottinger
Copy link
Contributor

ivan-ottinger commented Nov 10, 2021

The issue is caused by the following filter condition:

// Supported on Simple and Atomic Sites
if ( /^\/home/.test( path ) ) {
return ! site.is_vip && ! ( site.jetpack && ! site.options.is_automated_transfer );
}

introduced in #39090.

What happens here is that the whole pool of sites is filtered and as the condition ! site.is_vip && ! ( site.jetpack && ! site.options.is_automated_transfer ) returns false on every Jetpack site, it is being filtered out from the display.

I will take a closer look to see how this can be fixed.

Update: I have a working solution and will publish PR tomorrow.

@ivan-ottinger
Copy link
Contributor

Just noting here for clarity that the issue has been fixed in #57952.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack [Pri] Low Address when resources are available. Sites [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants