Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purchases: Remove unnecessary top margin in form in Edit Card Details page #839

Closed
stephanethomas opened this issue Nov 26, 2015 · 0 comments · Fixed by #7555
Closed

Purchases: Remove unnecessary top margin in form in Edit Card Details page #839

stephanethomas opened this issue Nov 26, 2015 · 0 comments · Fixed by #7555
Assignees
@gziolo
Labels
[Feature] Checkout The checkout screen and process for purchases made on WordPress.com. [Type] Bug When a feature is broken and / or not performing as intended
Milestone
Absinthe: backlog

Comments

@stephanethomas
Copy link
Contributor

We should get rid of the additional top margin on the Edit Card Details page:

screenshot

Note the <CreditCardForm /> is also used in the checkout - any change to that component should be tested in that flow as well.
@stephanethomas stephanethomas added [Feature] Checkout The checkout screen and process for purchases made on WordPress.com. [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. labels Nov 26, 2015
@fabianapsimoes fabianapsimoes added this to the Purchases: v2 milestone Nov 26, 2015
@lancewillett lancewillett added the [Type] Bug When a feature is broken and / or not performing as intended label Nov 30, 2015
@fabianapsimoes fabianapsimoes modified the milestones: Purchases: v2, Purchases: Future Feb 25, 2016
@fabianapsimoes fabianapsimoes removed the [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. label Mar 18, 2016
@fabianapsimoes fabianapsimoes modified the milestones: Gold: backlog, Purchases: Future Mar 18, 2016
@gziolo gziolo self-assigned this Aug 19, 2016
@gziolo gziolo mentioned this issue Aug 19, 2016
Merged
@gziolo gziolo added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Aug 19, 2016
@gziolo gziolo removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 22, 2016
@ajesse11x ajesse11x mentioned this issue Nov 4, 2022
Open
@awaisab172 awaisab172 mentioned this issue Nov 5, 2022
Open
@ajesse11x ajesse11x mentioned this issue Dec 25, 2022
Open
@awaisab172 awaisab172 mentioned this issue Dec 26, 2022
Open
@ajesse11x ajesse11x mentioned this issue Nov 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gziolo gziolo

Labels
[Feature] Checkout The checkout screen and process for purchases made on WordPress.com. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
Absinthe: backlog
Development

Successfully merging a pull request may close this issue.

Purchases: Remove unnecessary top margin in form in Edit Card Details page Automattic/wp-calypso
4 participants
@lancewillett @stephanethomas @gziolo @fabianapsimoes