Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the _check_required_properties in DataNodeConfigChecker #2330

Open
toan-quach opened this issue Dec 13, 2024 · 0 comments · May be fixed by #2422
Open

Refactor the _check_required_properties in DataNodeConfigChecker #2330

toan-quach opened this issue Dec 13, 2024 · 0 comments · May be fixed by #2422
Assignees
@toan-quach
Labels
Core: ⚙️ Configuration Core Related to Taipy Core 📈 Improvement Improvement of a feature. 🟧 Priority: High Must be addressed as soon 🔒 Staff only Can only be assigned to the Taipy R&D team

Comments

@toan-quach
Copy link
Member

toan-quach commented Dec 13, 2024 •
edited
Loading

Currently, the _check_required_properties in DataNodeConfigChecker has many hard-coded value, making it hard for future expansion and maintenance. We want to refactor this function to make it more generic similar to the current _check_class_type function in develop

What to do:

  • Refactor the _check_required_properties in DataNodeConfigChecker
  • Ensure existing tests do not break due to this (the behavior should remain the same)
@toan-quach toan-quach added Core Related to Taipy Core 📈 Improvement Improvement of a feature. Core: ⚙️ Configuration labels Dec 13, 2024
@jrobinAV jrobinAV added 🟧 Priority: High Must be addressed as soon 🔒 Staff only Can only be assigned to the Taipy R&D team labels Dec 18, 2024
@toan-quach toan-quach self-assigned this Jan 23, 2025
@toan-quach toan-quach linked a pull request Jan 23, 2025 that will close this issue
Open
5 tasks
@toan-quach toan-quach linked a pull request Jan 23, 2025 that will close this issue
feature/#2330 Refactor the _check_required_properties function #2422
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@toan-quach toan-quach

Labels
Core: ⚙️ Configuration Core Related to Taipy Core 📈 Improvement Improvement of a feature. 🟧 Priority: High Must be addressed as soon 🔒 Staff only Can only be assigned to the Taipy R&D team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature/#2330 Refactor the _check_required_properties function Avaiga/taipy
2 participants
@jrobinAV @toan-quach