feat(avm): poseidon2 in vm2 #11597
Merged
feat(avm): poseidon2 in vm2 #11597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 29, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
IlyasRidhuan
force-pushed
the
ir/01-10-feat_avm_constrained_ec_add
branch
2 times, most recently
from
5a378e0 to
d916f01
Compare
IlyasRidhuan
force-pushed
the
ir/01-10-feat_avm_constrained_ec_add
branch
from
d916f01 to
c176d6c
Compare
IlyasRidhuan
force-pushed
the
ir/01-28-feat_poseidon2_in_vm2
branch
2 times, most recently
from
038aa43 to
9e80f24
Compare
IlyasRidhuan
force-pushed
the
ir/01-10-feat_avm_constrained_ec_add
branch
2 times, most recently
from
35fce8a to
b103a20
Compare
IlyasRidhuan
force-pushed
the
ir/01-28-feat_poseidon2_in_vm2
branch
from
9e80f24 to
8ea0328
Compare
IlyasRidhuan
requested review from
jeanmon,
fcarreiro and
Maddiaa0
as code owners
IlyasRidhuan
force-pushed
the
ir/01-10-feat_avm_constrained_ec_add
branch
from
b103a20 to
7883080
Compare
fcarreiro
reviewed
Feb 12, 2025
| // Alpha (exponentiation): 5 | ||
| namespace poseidon2_params; | ||
| // Internal Matrix Diagonal (for partial rounds) | ||
| pol MU_0 = 7626475329478847982857743246276194948757851985510858890691733676098590062311; |
There was a problem hiding this comment.
I think Jean was suggesting we put these (well, for ECC) in the aztec constants so that you can use them both in PIL and C++? no strong preference from my side but worth considering
There was a problem hiding this comment.
hmm i think this is fine as is. They're already available in cpp through bb in nicer hex form anyways, while in PIL they need to be in this decimal format.
barretenberg/cpp/src/barretenberg/crypto/poseidon2/poseidon2.test.cpp
Outdated
Show resolved
Hide resolved
IlyasRidhuan
force-pushed
the
ir/01-10-feat_avm_constrained_ec_add
branch
from
7883080 to
73f9803
Compare
IlyasRidhuan
force-pushed
the
ir/01-28-feat_poseidon2_in_vm2
branch
2 times, most recently
from
0b4fd1c to
09bac87
Compare
IlyasRidhuan
force-pushed
the
ir/01-10-feat_avm_constrained_ec_add
branch
from
73f9803 to
dece8ee
Compare
IlyasRidhuan
force-pushed
the
ir/01-28-feat_poseidon2_in_vm2
branch
from
09bac87 to
7bd3cc6
Compare
Base automatically changed from
ir/01-10-feat_avm_constrained_ec_add
to
master
February 13, 2025 10:32
IlyasRidhuan
force-pushed
the
ir/01-28-feat_poseidon2_in_vm2
branch
from
7bd3cc6 to
2df2297
Compare
fcarreiro
reviewed
Feb 13, 2025
| } // namespace bb::avm2::simulation |
There was a problem hiding this comment.
|
|
||
| std::vector<Poseidon2PermutationEvent> event_results = perm_event_emitter.dump_events(); | ||
|
|
||
| EXPECT_EQ(result, expected); |
There was a problem hiding this comment.
You should still use a container matcher. If you want to reuse your expected variable, you can use ElementsAreArray(). Same in the other EXPECT_EQ against expected. (and in other tests).
IlyasRidhuan
force-pushed
the
ir/01-28-feat_poseidon2_in_vm2
branch
from
2df2297 to
3b7e83a
Compare
IlyasRidhuan
force-pushed
the
ir/01-28-feat_poseidon2_in_vm2
branch
from
3b7e83a to
ee53456
Compare
fcarreiro
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read contributing guidelines and remove this line.