Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename generic representing a note from Note to NOTE everywhere in Aztec.nr #12260

Closed
benesjan opened this issue Feb 25, 2025 · 2 comments
Closed

Rename generic representing a note from Note to NOTE everywhere in Aztec.nr #12260

benesjan opened this issue Feb 25, 2025 · 2 comments
Assignees
@benesjan
Labels
team-fairies Nico's team

Comments

@benesjan
Copy link
Contributor

This is because Note looks like a type and we always use capitalized names for generics.
@benesjan benesjan added the team-fairies Nico's team label Feb 25, 2025
@benesjan benesjan self-assigned this Feb 25, 2025
This was referenced Feb 25, 2025
Merged
Closed
@iAmMichaelConnor
Copy link
Contributor

Actually, rust uses PascalCase for generics

@benesjan
Copy link
Contributor Author

Not planned. Mike was right 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesjan benesjan

Labels
team-fairies Nico's team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: renaming Note generic as NOTE AztecProtocol/aztec-packages
2 participants
@benesjan @iAmMichaelConnor