Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Notes): Add pagination to noir get/view-notes #4262

Closed
Tracked by #2783
LHerskind opened this issue Jan 29, 2024 · 1 comment
Closed
Tracked by #2783

feat(Notes): Add pagination to noir get/view-notes #4262

LHerskind opened this issue Jan 29, 2024 · 1 comment

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Jan 29, 2024

See comment from @rahul-kothari in #2806.

Currently, both our get and view notes functions support passing an offset which can be used for pagination. However, it need to be supported by the application to actually be used.

I'm not sure we can really push this to devs as it is quite easy to forget it, so possibly it is better to see if we should feed in the value from an oracle, which have a base-value of 0. For example, say that we use a get_note_offset_oracle which is used when viewing or getting notes. Offset can then be used without needing to alter applications, and should allow us to execute a .view() along with updates offset such that we can handle fetching "all" notes in ts side of things by looking through notes and extending the offset until no more notes are found.

@LHerskind LHerskind added this to A3 Jan 29, 2024
@LHerskind LHerskind converted this from a draft issue Jan 29, 2024
@LHerskind LHerskind changed the title feat: Add pagination to noir get/view-notes feat(Notes): Add pagination to noir get/view-notes Mar 8, 2024
@LHerskind
Copy link
Contributor Author

Will be closing this since it is merely something that applications really need to deal with.

@LHerskind LHerskind closed this as not planned Won't fix, can't repro, duplicate, stale Jun 11, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants