Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export Slow Update tree dependencies via aztec.js #4413

Closed
rahul-kothari opened this issue Feb 5, 2024 · 1 comment
Closed

Re-export Slow Update tree dependencies via aztec.js #4413

rahul-kothari opened this issue Feb 5, 2024 · 1 comment
Labels
T-bug Type: Bug. Something is broken.

Comments

@rahul-kothari
Copy link
Contributor

Currently e2e test imports @aztec/kv-store and @aztec/merkle-tree. But users shouldn't be using these packages. So:

  1. Re-export required methods via aztec.js
  2. Add a comment in e2e package.json - telling devs not to import additional packages there (since e2e should be a relfection of what external devs do)
  3. Add a linter rule in e2e so we don't do this again.
@rahul-kothari rahul-kothari added the T-bug Type: Bug. Something is broken. label Feb 5, 2024
@github-project-automation github-project-automation bot moved this to Todo in A3 Feb 5, 2024
@rahul-kothari
Copy link
Contributor Author

closed in #4483

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: Bug. Something is broken.
Projects
Archived in project
Development

No branches or pull requests

1 participant