Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit breaking flag of sub-PRs in batch-mirror Noir PRs #5612

Closed
Savio-Sou opened this issue Apr 8, 2024 · 1 comment
Closed

Inherit breaking flag of sub-PRs in batch-mirror Noir PRs #5612

Savio-Sou opened this issue Apr 8, 2024 · 1 comment
Labels
A-devops Area: Devops. E.g. CI / build systems

Comments

@Savio-Sou
Copy link
Member

Context

Noir changes happening in this repository are currently mirrored in batches to the Noir repository (e.g. noir-lang/noir#4657).

Problem

Sub-PRs within the batches could be breaking PRs (i.e. backward incompatible) containing breaking changes.

But their breaking flags don't bubble up to the batch PR itself, makes spotting breaking changes in the Noir repo less trivial than it should be.

Screenshot 2024-04-08 at 09 30 26

Happy case

When ≥1 sub-PR is breaking, batch-mirror PR is flipped breaking (i.e. adds ! in title).

@Savio-Sou Savio-Sou added the A-devops Area: Devops. E.g. CI / build systems label Apr 8, 2024
@github-project-automation github-project-automation bot moved this to Todo in A3 Apr 8, 2024
@Savio-Sou
Copy link
Member Author

Commit overrides in the sync PR bodies sufficiently communicate individual breaking PRs.

@Savio-Sou Savio-Sou closed this as not planned Won't fix, can't repro, duplicate, stale Apr 8, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Devops. E.g. CI / build systems
Projects
Archived in project
Development

No branches or pull requests

1 participant