Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate chain id in the account contract #656

Closed
spalladino opened this issue May 23, 2023 · 2 comments
Closed

Validate chain id in the account contract #656

spalladino opened this issue May 23, 2023 · 2 comments

Comments

@spalladino
Copy link
Collaborator

Include the chainId as part of the payload to the account contract. Add an oracle call to retrieve the current chainId from Noir. Validate that both match in the account contract entrypoint.

@spalladino spalladino added this to the 👍 Account Abstraction milestone May 23, 2023
@spalladino spalladino added this to A3 May 23, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 May 23, 2023
@LeilaWang
Copy link
Collaborator

Adding an oracle call to get chainId might not be needed, since that's something being done privately. The prover gets to control what's being returned to the simulator. But what will be great to do, is adding the chainId to the final public inputs, and check it all the way up, so that a proof can only be submitted to the specific chain.

@spalladino
Copy link
Collaborator Author

You're totally right! Closing this issue in favor of #705.

@spalladino spalladino closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 May 29, 2023
@iAmMichaelConnor iAmMichaelConnor removed this from A3 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants