Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor process function of NoteProcessor to accept block only #6830

Closed
benesjan opened this issue Jun 3, 2024 · 0 comments · Fixed by #6870
Closed

Refactor process function of NoteProcessor to accept block only #6830

benesjan opened this issue Jun 3, 2024 · 0 comments · Fixed by #6870
Assignees
@benesjan

Comments

@benesjan
Copy link
Contributor

benesjan commented Jun 3, 2024

NoteProcessor.process has a block and encrypted logs on the input. This makes no sense as the encrypted logs are contained within a block. It's a tech debt from time this was not the case and it should be address as it's convoluting the code.
@benesjan benesjan self-assigned this Jun 3, 2024
@github-project-automation github-project-automation bot moved this to Todo in A3 Jun 3, 2024
@benesjan benesjan mentioned this issue Jun 4, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesjan benesjan

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: note processor cleanup AztecProtocol/aztec-packages
1 participant
@benesjan