refactor: ServerCircuitProver return values #9391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexghr
changed the title
alexghr
force-pushed
the
ag/refactor-avm-proof-fields
branch
from
527a4c9 to
6ec88c6
Compare
alexghr
force-pushed
the
ag/refactor-avm-proof-fields
branch
from
5351c4b to
6ec88c6
Compare
ludamad
reviewed
Oct 24, 2024
| @@ -427,7 +425,7 @@ export class MemoryProvingQueue implements ServerCircuitProver, ProvingJobSource | |||
| inputs: AvmCircuitInputs, | |||
| signal?: AbortSignal, | |||
| epochNumber?: number, | |||
| ): Promise<ProofAndVerificationKey<Proof>> { | |||
| ): Promise<ProofAndVerificationKey<number>> { | |||
There was a problem hiding this comment.
Wonder if type Unbounded = number is too hacky :)
There was a problem hiding this comment.
Ah good shout! I think it would it clean and I can leave a comment at the definition point about it
ludamad
reviewed
Oct 24, 2024
| @@ -36,18 +36,30 @@ export class MockProver implements ServerCircuitProver { | |||
| getAvmProof() { | |||
| return Promise.resolve( | |||
| makeProofAndVerificationKey( | |||
| makeEmptyProof(), | |||
| makeEmptyRecursiveProof<number>(0), | |||
There was a problem hiding this comment.
I'm not really sure why the type is even called recursive proof, why separates it structurally from a non-recursive proof?
There was a problem hiding this comment.
I think it's a leftover from when we were proving with plonk
There was a problem hiding this comment.
Indeed, all the (non)recursive proof terminology comes from the days of plonk
ludamad
approved these changes
Oct 24, 2024
alexghr
force-pushed
the
ag/refactor-avm-proof-fields
branch
from
6ec88c6 to
ca65f95
Compare
alexghr
added a commit
that referenced
this pull request
Nov 15, 2024
just-mitch
pushed a commit
that referenced
this pull request
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes some of the types returned by functions on the
ServerCircuitProverinterface to make them more friendly for serialisation/deserialisation