-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: Remove recursive
from ACIR format; add them to API and CLI
#9479
Conversation
recursive
from ACIR format; add them to API and CLIrecursive
from ACIR format; add them to API and CLI (DRAFT)
0174639
to
e0f0fe7
Compare
recursive
from ACIR format; add them to API and CLI (DRAFT)recursive
from ACIR format; add them to API and CLI
I think yes as we could want to test recursive proof generation (these methods are mostly used for our CI) |
5bda036
to
b57695c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to re-add recursive testing for assert_statement
. We should be good to go after this.
Co-authored-by: Tom French <[email protected]>
Co-authored-by: Tom French <[email protected]>
…ec-packages into 6185-rm-recursive-attr
Looks like there's a bash issue with adding the recursive flag to the CLI args. |
…ec-packages into 6185-rm-recursive-attr
…ec-packages into 6185-rm-recursive-attr
c5e4c46
to
0e38181
Compare
Resolves noir-lang/noir#6185
recursive
field from ACIR formats and theCircuit
definition--recursive
tobb
CLIrecursive
tomain.ts
, the backend API and WasmThis is effectively undoing a lot of what was done here. Interestingly there many more Wasm methods that need the
recursive
parameter now: whereas previously onlyacir_create_proof
andacir_verify_proof
used it, now anything that callscreate_circuit
needs it because circuit creation builds all the constraints already, which depend on this.TODO:
#[recursive]
attribute from Noir#[recursive]
fromnoir-protocol-circuits
bb-prover
where it uses usesnoir-protocol-circuits
to use the correctrecursive
flag--recursive
tocli.ts
underbb-prover
executeBB
and pass--recursive
if it calls abb
command that needs it