feat(deploys): OTEL_RESOURCE_ATTRIBUTES #9642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maddiaa0
approved these changes
Nov 1, 2024
ludamad
pushed a commit
that referenced
this pull request
Nov 1, 2024
Adds service names complementary to #9642
stevenplatt
added a commit
that referenced
this pull request
Nov 4, 2024
# Change log - **OTEL resource attribute to metric label conversion** In addition to work for adding OTEL resource attributes in PR #9642 , a second configuration is needed for OTEL to convert these into metrics labels as outlined in opentelemetry-collector-contrib PR [#15349](open-telemetry/opentelemetry-collector-contrib#15349). If the resource attribute is node converted into a metics label, they arrive to Prometheus with the namespace set as `metrics`, which is where the OTEL collector is installed and not the application itself. This change has ben tested by reinstalling the metrics charts into the spartan cluster and confirming namespace was an available label on metrics arriving to prometheus. (I manually connected to prometheus to query, rather than downstream Grafana). - **Added kube-state-metrics to prometheus** Kube state metrics exposes kubernetes cluster stats to prometheus. This is needed currently to show CPU usage in Grafana dashboards (since this is not an application metric). More info: https://github.com/kubernetes/kube-state-metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds k8s environment to otel resources bringing back parity with filtering when we had the daemonset
