feat(avm): hinting merkle trees #9658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @IlyasRidhuan and the rest of your teammates on |
IlyasRidhuan
force-pushed
the
ir/10-31-feat_avm_start_merkle
branch
2 times, most recently
from
68f39f4 to
d12f6fb
Compare
dbanks12
force-pushed
the
ir/10-31-feat_avm_start_merkle
branch
from
d12f6fb to
f6220e4
Compare
dbanks12
added a commit
that referenced
this pull request
Nov 12, 2024
This builds on the base PR #9658, cleans things up a bit, and starts updating tests. - Adds some public storage tests to `avm_simulator.test.ts` that test with a real merkle tree. - Adds a flag to toggle use of real merkle ops in state manager (sets that flag for all old tests) - Changes trace functions to allow all merkle args to be undefined (e.g. when flag is set) I haven't: - Added real merkle tests for nullifier, note hash, message ops - Updated the state manager tests with some real merkle tests - Updated opcode tests with real merkle tests (if we even want that)
dbanks12
force-pushed
the
ir/10-31-feat_avm_start_merkle
branch
from
5617383 to
14947dd
Compare
dbanks12
requested review from
fcarreiro,
dbanks12 and
jeanmon
as code owners
dbanks12
changed the title
dbanks12
added
the
e2e-all
Changes to public function bytecode sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
IlyasRidhuan
changed the title
IlyasRidhuan
force-pushed
the
ir/10-31-feat_avm_start_merkle
branch
from
006f804 to
00f1256
Compare
dbanks12
approved these changes
Nov 12, 2024
dbanks12
force-pushed
the
ir/10-31-feat_avm_start_merkle
branch
from
00f1256 to
2bca46c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read contributing guidelines and remove this line.