Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Devops for proving large blocks #9795

Merged
merged 71 commits into from
Nov 12, 2024
Merged

chore: Devops for proving large blocks #9795

merged 71 commits into from
Nov 12, 2024

Conversation

PhilWindle
Copy link
Collaborator

This PR contains some work towards testing the proving of large blocks.

@@ -25,7 +25,7 @@ bootNode:
externalUdpHost: ""
replicas: 1
service:
p2pTcpPort: 40400
p2pTcpPort: 40500
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm what's the issue with the same port being used?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None, this change was when I was messing about with routing UDP into the cluster. Will revert

@PhilWindle PhilWindle changed the base branch from release/testnet-1 to master November 11, 2024 14:22
Copy link
Contributor

@alexghr alexghr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Comment on lines 703 to 706
# TODO(#9736)
# - test: transfer.test.ts
# values: 48-validators
# runner_type: 32core-tester-x86
# TODO(#9736) this fails
- test: transfer.test.ts
values: 48-validators
runner_type: 32core-tester-x86
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the "this fails" comment still relevant?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, I didn't actually uncomment this

Copy link
Collaborator

@ludamad ludamad Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The uncomment might have been a result of me trying the test out on testnet branch - it was indeed relevant I was just tryint to surface it but expected the failure. Would recommend removing it especially as this is not labelled with network-all

Comment on lines +80 to +81
resources:
{{- toYaml .Values.proverAgent.resources | nindent 12 }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@PhilWindle PhilWindle enabled auto-merge (squash) November 12, 2024 14:15
Copy link
Contributor

Changes to public function bytecode sizes

Generated at commit: 3294dc76149037bad914a90e9e1063a3e6f35249, compared to commit: abdd912bd0d3cf9a8e09339a3766c61eea712ede

🧾 Summary (100% most significant diffs)

Program Bytecode size in bytes (+/-) %
TokenBridge::constructor +118 ❌ +3.64%
TokenBridge::public_dispatch -681 ✅ -3.01%

Full diff report 👇
Program Bytecode size in bytes (+/-) %
TokenBridge::constructor 3,362 (+118) +3.64%
TokenBridge::public_dispatch 21,955 (-681) -3.01%

@PhilWindle PhilWindle merged commit 7a70b81 into master Nov 12, 2024
66 checks passed
@PhilWindle PhilWindle deleted the pw/spartan-proving branch November 12, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants