Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing test token contract artifact #9906

Merged

Conversation

IlyasRidhuan
Copy link
Contributor

Please read contributing guidelines and remove this line.

@IlyasRidhuan IlyasRidhuan marked this pull request as ready for review November 12, 2024 16:11
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @IlyasRidhuan and the rest of your teammates on Graphite Graphite

@IlyasRidhuan IlyasRidhuan enabled auto-merge (squash) November 12, 2024 16:24
Copy link
Contributor

Changes to circuit sizes

Generated at commit: 3639797bb32c8f45b89e6c03fd84d4e8e5c0ace8, compared to commit: eac5fb5f30997364bf45262f898cfeedb97b1a71

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_tail_to_public 0 ➖ 0.00% +7 ❌ +0.02%
private_kernel_empty -1 ✅ -0.16% -1 ✅ -0.00%
rollup_base_private 0 ➖ 0.00% -7 ✅ -0.00%
private_kernel_reset -2 ✅ -0.00% -2 ✅ -0.00%
rollup_base_public 0 ➖ 0.00% -94 ✅ -0.00%
private_kernel_reset_4_4_4_4_4_4_4_4_1 -2 ✅ -0.01% -3 ✅ -0.00%
private_kernel_inner -3 ✅ -0.01% -3 ✅ -0.01%
private_kernel_tail -2 ✅ -0.04% -1 ✅ -0.01%
private_kernel_init -5 ✅ -0.02% -5 ✅ -0.01%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_tail_to_public 18,849 (0) 0.00% 31,297 (+7) +0.02%
private_kernel_empty 607 (-1) -0.16% 942,834 (-1) -0.00%
rollup_base_private 332,869 (0) 0.00% 3,432,515 (-7) -0.00%
private_kernel_reset 84,096 (-2) -0.00% 618,116 (-2) -0.00%
rollup_base_public 470,052 (0) 0.00% 3,770,556 (-94) -0.00%
private_kernel_reset_4_4_4_4_4_4_4_4_1 32,454 (-2) -0.01% 86,599 (-3) -0.00%
private_kernel_inner 38,067 (-3) -0.01% 57,508 (-3) -0.01%
private_kernel_tail 4,490 (-2) -0.04% 13,042 (-1) -0.01%
private_kernel_init 21,703 (-5) -0.02% 34,866 (-5) -0.01%

@IlyasRidhuan IlyasRidhuan merged commit c366c69 into master Nov 12, 2024
107 of 108 checks passed
@IlyasRidhuan IlyasRidhuan deleted the ir/11-12-fix_removing_test_token_contract_artifact branch November 12, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants