Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: testing commands in CLI docs #2119

Merged
merged 23 commits into from
Sep 11, 2023
Merged

feat: testing commands in CLI docs #2119

merged 23 commits into from
Sep 11, 2023

Conversation

benesjan
Copy link
Contributor

@benesjan benesjan commented Sep 8, 2023

Fixes #1893

Note: It replaces the incorrect private key value in docs. The problematic command was:

aztec-cli create-account --private-key 0x6622c828e9cd5adc86f10878765fe921d2b8cb2c79bdbc391157e43811ce88e3

This could bite users so we should ideally merge this before next release.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@benesjan benesjan marked this pull request as draft September 8, 2023 10:00
@benesjan benesjan mentioned this pull request Sep 8, 2023
4 tasks
@benesjan benesjan force-pushed the janb/cli_docs_test branch 2 times, most recently from bbe1681 to 4e8bc87 Compare September 8, 2023 15:17
@benesjan benesjan marked this pull request as ready for review September 9, 2023 09:48
@PhilWindle PhilWindle enabled auto-merge (squash) September 11, 2023 11:23
@PhilWindle PhilWindle disabled auto-merge September 11, 2023 11:51
@PhilWindle PhilWindle merged commit 73328db into master Sep 11, 2023
@PhilWindle PhilWindle deleted the janb/cli_docs_test branch September 11, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add tests for the sh commands in docs/getting_started/cli.md
2 participants