Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove acir goblin flow #6724

Merged
merged 6 commits into from
May 29, 2024
Merged

chore: remove acir goblin flow #6724

merged 6 commits into from
May 29, 2024

Conversation

ledwards2225
Copy link
Contributor

@ledwards2225 ledwards2225 commented May 28, 2024 •
edited
Loading

Removes the Goblin-related flows from bb and bb.js. They were based on an overcomplicated and outdated model and do not test anything that is not tested elsewhere.

@ledwards2225 ledwards2225 self-assigned this May 28, 2024
@AztecBot
Copy link
Collaborator

AztecBot commented May 28, 2024 •
edited
Loading

Benchmark results

Metrics with a significant change:

  • protocol_circuit_witness_generation_time_in_ms (root-parity): 66.9 (+37%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric 1 threads 4 threads 16 threads 32 threads 64 threads
proof_construction_time_sha256 5,682 1,547 708 764 (+1%) 779 (+1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 1,412 1,412 1,412
l1_rollup_calldata_gas 9,464 9,428 9,452
l1_rollup_execution_gas 616,105 616,069 616,093
l2_block_processing_time_in_ms 1,288 4,790 9,680 (+2%)
l2_block_building_time_in_ms 44,674 177,417 357,929 (+1%)
l2_block_rollup_simulation_time_in_ms 44,506 176,796 356,688 (+1%)
l2_block_public_tx_process_time_in_ms 24,014 (+2%) 100,581 206,485 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 3 blocks 5 blocks
node_history_sync_time_in_ms 9,395 (-2%) 14,419 (-1%)
node_database_size_in_bytes 14,516,304 21,364,816
pxe_database_size_in_bytes 18,071 29,868

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit simulation_time_in_ms witness_generation_time_in_ms proving_time_in_ms input_size_in_bytes output_size_in_bytes proof_size_in_bytes num_public_inputs size_in_gates
private-kernel-init 160 (-1%) 3,758 22,528 (+2%) 20,630 64,614 89,536 2,731 1,048,576
private-kernel-inner 625 4,461 (+1%) 42,368 92,318 64,614 89,536 2,731 2,097,152
private-kernel-tail 567 3,094 (-3%) 36,428 96,541 77,498 10,656 266 2,097,152
base-parity 6.52 (-1%) 1,147 2,923 (+2%) 128 64.0 2,208 2.00 131,072
root-parity 49.9 ⚠️ 66.9 (+37%) 44,157 27,084 64.0 2,720 18.0 2,097,152
base-rollup 743 (-2%) 2,249 74,200 119,610 756 3,648 47.0 4,194,304
root-rollup 112 62.2 19,628 (+1%) 25,297 620 3,456 41.0 1,048,576
public-kernel-app-logic 525 (+1%) 3,007 47,656 (+1%) 104,941 86,302 114,784 3,520 2,097,152
public-kernel-tail 1,087 22,808 (+2%) 154,251 395,386 7,522 10,656 266 8,388,608
private-kernel-reset-small 591 2,089 (+1%) 45,284 (-1%) 120,733 64,614 89,536 2,731 2,097,152
merge-rollup 28.9 N/A N/A 16,534 756 N/A N/A N/A
public-kernel-setup 637 (-1%) N/A N/A 104,941 86,302 N/A N/A N/A
public-kernel-teardown 537 (-1%) N/A N/A 104,941 86,302 N/A N/A N/A
private-kernel-tail-to-public N/A 8,738 (+1%) 91,247 N/A N/A 114,784 3,520 4,194,304

Stats on running time collected for app circuits

Function input_size_in_bytes output_size_in_bytes witness_generation_time_in_ms proof_size_in_bytes proving_time_in_ms size_in_gates num_public_inputs
ContractClassRegisterer:register 1,344 9,944 466 (-1%) N/A N/A N/A N/A
ContractInstanceDeployer:deploy 1,408 9,944 42.1 (-1%) N/A N/A N/A N/A
MultiCallEntrypoint:entrypoint 1,920 9,944 1,440 N/A N/A N/A N/A
SchnorrAccount:constructor 1,312 9,944 996 N/A N/A N/A N/A
SchnorrAccount:entrypoint 2,304 9,944 2,095 (+1%) 16,768 50,953 2,097,152 457
Token:privately_mint_private_note 1,280 9,944 1,137 N/A N/A N/A N/A
Token:transfer 1,376 9,944 4,101 (+1%) 16,768 45,736 2,097,152 457
Benchmarking:create_note 1,312 9,944 950 N/A N/A N/A N/A
FPC:fee_entrypoint_public 1,344 9,944 222 N/A N/A N/A N/A
SchnorrAccount:spend_private_authwit 1,280 9,944 78.9 (+2%) N/A N/A N/A N/A
Token:unshield 1,376 9,944 3,407 (+5%) N/A N/A N/A N/A
FPC:fee_entrypoint_private 1,376 9,944 4,188 (+4%) N/A N/A N/A N/A

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.5 17.0 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.7 31.8 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.608 0.522 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 48.7 (-1%) 76.3 (-1%) 245 (-1%) 474 927 1,866 (+1%) N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.497 (-1%) 0.470 (-1%) 0.445 (-1%) 0.443 0.439 0.445 (+1%) N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 58.6 (-1%) 113 355 698 (-1%) 1,382 2,803 (+2%) N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 106 208 692 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.508 (-1%) 0.504 0.481 0.479 0.478 0.486 (+2%) N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 62.7
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 107
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.557

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 83,794 665,117

Transaction size based on fee payment method

| Metric | |
| - | |

@ledwards2225 ledwards2225 marked this pull request as ready for review May 29, 2024 04:05
@ledwards2225 ledwards2225 requested a review from ludamad May 29, 2024 13:13
@ledwards2225 ledwards2225 merged commit f035231 into master May 29, 2024
86 checks passed
@ledwards2225 ledwards2225 deleted the lde/delete_goblin_flow branch May 29, 2024 14:41
@AztecBot AztecBot mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludamad ludamad ludamad approved these changes

Assignees

@ledwards2225 ledwards2225

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ledwards2225 @AztecBot @ludamad