Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency Refinement #1905

Open
jeremiahhoward opened this issue Jan 31, 2025 · 2 comments
Open

Consistency Refinement #1905

jeremiahhoward opened this issue Jan 31, 2025 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@jeremiahhoward
Copy link
Member

Would this be possible?
Describe the bug
Assignment Default parameters are inconsistent with custom policy parameter default values. This presents a challenge in some CI/CD situations that rely on the definition of the configured source, rather than use of a custom assignment. As these policies are referenced widely, it will improve universal consistency to align these values.

Steps to reproduce

  1. Review default values for listOfResourceTypesNotAllowed for https://github.com/Azure/Enterprise-Scale/blob/main/src/resources/Microsoft.Authorization/policySetDefinitions/Enforce-ALZ-Sandbox.json
  2. Review the values contained in https://github.com/Azure/Enterprise-Scale/blob/main/eslzArm/managementGroupTemplates/policyAssignments/ENFORCE-ALZ-SandboxPolicyAssignment.json
@jeremiahhoward jeremiahhoward added the bug Something isn't working label Jan 31, 2025
@Springstone
Copy link
Member

@jeremiahhoward thanks for reaching out.

For this issue, we have historically used the defaults from built-in policies being referenced in the initiative (policySet), which is an empty array. This helps us manage integration of built-in definitions over time, especially in the policy versioning world.

Technically, because this is a custom ALZ initiative, it would be possible to make the default values of the initiative match the assignment.

Is this issue causing you pain? What is the specific issue?

@Springstone Springstone self-assigned this Feb 3, 2025
@jeremiahhoward
Copy link
Member Author

jeremiahhoward commented Feb 3, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants