Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinning wheel animation spamming scenario testing output #66

Closed
vmarcella opened this issue Sep 29, 2023 · 6 comments
Closed

Spinning wheel animation spamming scenario testing output #66

vmarcella opened this issue Sep 29, 2023 · 6 comments
Labels
bug Something isn't working enhancement New feature or request innovation engine

Comments

@vmarcella
Copy link
Member

vmarcella commented Sep 29, 2023

The github actions terminal doesn't support us rendering characters in place so the spinning wheel animation used to indicate the progress of a command/step renders across multiple lines instead of on one.

@nellyk
Copy link
Member

nellyk commented Jun 10, 2024

@vmarcella our team is currently using this for github actions. Did this get resolved for you?

@rgardler-msft
Copy link
Collaborator

Assuming this is not a simple fix, can we add a command line switch to prevent the animation effect. Even better if we can detect if the terminal being run in supports in-place. When disabled the animation would be replaced by an ever growing "...." output

@zioproto
Copy link

The ie test command has the following options:

Global Flags:
      --environment string    The environment that the CLI is running in. (local, ci, ocd) (default "local")

Should the ci option the one to be used for GitHub actions ? What is ocd ?

@mbifeld
Copy link
Member

mbifeld commented Jun 12, 2024

The spinning wheel issue should be resolved in the ie test UX refresh in this PR: #198

@mbifeld
Copy link
Member

mbifeld commented Jun 12, 2024

@vmarcella can you clarify if ci flag should be used for GitHub Actions?

@zioproto ocd stands for "one click deploy" and is used internally by Portal team. It should probably be removed from the public help command details.

Made an issue for improving the details in ie __ --help here: #201.

@vmarcella
Copy link
Member Author

The spinning wheel issue for ie test is going to be fixed in #198.

As for the --environment, I wouldn't worry about setting it for ie test as the default parameter will suffice and ie test doesn't actually treat the environments as different (ie execute and ie interactive do, though). I will update the documentation in a future PR to better describe when to modify the environment flag.

@github-project-automation github-project-automation bot moved this from 🆕 Backlog to ✅ Done in Innovation Engine Backlog Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request innovation engine
Projects
Status: ✅ Done
Development

No branches or pull requests

5 participants