[QoS] Dynamic buffer calculation #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
stephenxs
force-pushed
the
dynamic-buffer-calculation
branch
from
282f9cf to
fd878ea
Compare
stephenxs
force-pushed
the
dynamic-buffer-calculation
branch
from
601b4f3 to
77ce059
Compare
another table and add SAI interface to fetch it.
stephenxs
force-pushed
the
dynamic-buffer-calculation
branch
from
77ce059 to
abb574f
Compare
Add logic of handling buffer related CONFIG_DB Add definition of lua plugin for calculating headroom and shared buffer pool and for checking legality of the accumulative headroom of a port Fix typo in well-known formula Correct the errors in command section.
Fix some minor errors Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
To run lossless traffic on a PG other than 3-4, maps in PORT_QOS_MAP should also be configured properly, which needs to be done manually. Signed-off-by: Stephen Sun <[email protected]>
|
@neethajohn |
liat-grozovik
approved these changes
Sep 23, 2020
neethajohn
approved these changes
Sep 23, 2020
For vendors supporting dynamic buffer calculation, - newly installed switch run dynamic mode - upgraded switch with all buffer configuration aligning the default, run dynamic mode - otherwise, run traditional mode Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're going to improve the way we calculating headroom size. Originally we generate headroom size by looking up the predefined lookup table.
We will have the following groups of parameters
Based on the parameters and a well-known formula the code in buffer manager will do the calculation and not take it from pre-defined values as we have today.
On top of that, need an ability to override headroom and do not calculate it in the code.