Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update to golang v1.23 #265

Merged
merged 5 commits into from
Oct 24, 2024
Merged

chore: update to golang v1.23 #265

merged 5 commits into from
Oct 24, 2024

Conversation

christinalau0
Copy link
Contributor

Reason for Change:

  • Update golang from v1.20 to v1.23
    • No vendor folder changes
    • Update golang dev image to 1.23.2-bullseye
  • Update golangci-lint to v1.61.0 to support golang v1.23
    • Fixed new lint errors
    • Disabled revive linter as it threw hundreds of unused parameter errors. This can be fixed in a later PR.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@christinalau0
Copy link
Contributor Author

Verified successful run with Azure E2E PR pipeline.

JesusAlvarezTorres
JesusAlvarezTorres approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@JesusAlvarezTorres JesusAlvarezTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@christinalau0 christinalau0 merged commit c3f4c11 into Azure:master Oct 24, 2024
2 checks passed
@christinalau0 christinalau0 deleted the go-1.23 branch October 24, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jadarsie jadarsie jadarsie approved these changes

@JesusAlvarezTorres JesusAlvarezTorres JesusAlvarezTorres approved these changes

@haofan-ms haofan-ms Awaiting requested review from haofan-ms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christinalau0 @JesusAlvarezTorres @jadarsie