fix: Fix enableTelemetry apiVersion and ARM template #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christinalau0
requested review from
JesusAlvarezTorres,
jadarsie and
haofan-ms
jadarsie
previously approved these changes
Nov 19, 2024
JesusAlvarezTorres
previously approved these changes
Nov 19, 2024
christinalau0
dismissed stale reviews from JesusAlvarezTorres and jadarsie
via
374c735
christinalau0
changed the title
JesusAlvarezTorres
previously approved these changes
Nov 20, 2024
jadarsie
approved these changes
Nov 20, 2024
|
Verified successful run with ADO PR E2E pipeline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Specifying feature flag enableTelemetry: True would cause the ARM template deployment to fail. This PR bumps the api version and removes the DeploymentARMResource alias to fix the issue.
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: