Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typing]list[typeA or typeB] needs to be list[typeA] or list[typeB] in doc string #2966

Closed
xiangyan99 opened this issue Dec 13, 2024 · 2 comments

Comments

@xiangyan99
Copy link
Member

E.g. in our generated code, we have

:vartype char_filters: list[str or ~azure.search.documents.indexes.models.CharFilterName]

it should be

:vartype char_filters: list[str] or list[~azure.search.documents.indexes.models.CharFilterName]

to make our doc tool happy.

@iscai-msft
Copy link
Contributor

Is the suggested response correct? I believe we do allow users to input a list that contains both strings and enums, we don't only allow users to input either a list of string or a list of enum

@iscai-msft
Copy link
Contributor

gentle ping on this. I'm going to close this issue as part of our migration to the microsoft/typespec repo. If you think that this is still an issue, can you reopen on the microsoft/typespec repo? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants