Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it possible to use absolutely import inner Python SDK instead of relative import #2999

Open
msyyc opened this issue Jan 10, 2025 · 1 comment
Open

Is it possible to use absolutely import inner Python SDK instead of relative import #2999

msyyc opened this issue Jan 10, 2025 · 1 comment
Assignees
@msyyc
Labels
design-discussion An area of design currently under discussion and open to team and community feedback.

Comments

@msyyc
Copy link
Member

msyyc commented Jan 10, 2025 •
edited
Loading

Currently we always use relative import inner Python SDK (e.g. here), which needs complicated implementation logic in python codegen and the logic is not easy to maintain. In comparison, absolute import is very easy to implement and it doesn't influence SDK users. I think it is worth to discuss.
@msyyc msyyc added the design-discussion An area of design currently under discussion and open to team and community feedback. label Jan 10, 2025
@msyyc msyyc self-assigned this Jan 10, 2025
@msyyc
Copy link
Member Author

msyyc commented Jan 10, 2025

I update azure-mgmt-trustedsigning with absolute import manually and it passes all the test : https://github.com/Azure/azure-sdk-for-python/pull/39107/files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msyyc msyyc

Labels
design-discussion An area of design currently under discussion and open to team and community feedback.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@msyyc