-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't introduce root namespace "Platform" #141
Comments
when i reference this nuget |
This is still causing a problem as of the latest published NuGet package which is still v2.5.12 as of November 10 2022. Specifically, it causes a conflict when importing the package into Unity since Unity's render pipeline has their own enum type named Platform and it conflicts with the Platform.System.Text namespace defined in v2.5.12 of Microsoft.Azure.Amqp. See this Unity issue for reference. I see this was fixed 4 years ago on November 8 2018 when the PlatformSupport.cs file was removed, but the change doesn't seem to have made it to NuGet yet. @xinchen10 any idea when the current code will make its way to NuGet? |
I have the same problem. Blocking issue. |
Same here. I have been able to make it work by building it myself and allowing unsafe code in my project: https://github.com/Azure/azure-amqp |
This is also blocking us as well, our whole codebase is prefixed "Platform" which is going to be a nightmare to unravel. |
Checking to see if there's a release date for this fix. Running into similar namespace conflicts. Thanks. |
Background
Adding Microsoft.Azure.Amqp NuGet package to an existing project.
Problem
The package introduces a root namespace "Platform" (essentially only
Platform.System.Text
), which results in some name clashes for us.Expected behavior
No such root namespace, especially since it feels unneeded.
Either place the
System.Text.Encoding
wrapping that is done in PlatformSupport.cs somewhere in theMicrosoft.Azure.Amqp
namespace, or directly useSystem.Text.Encoding
with the corresponding directives.The text was updated successfully, but these errors were encountered: