Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File version of Microsoft.Azure.Amqp is not updated with releases #241

Closed
TinkerAMS opened this issue Mar 6, 2023 · 0 comments
Closed

Comments

@TinkerAMS
Copy link

The file version of Microsoft.Azure.Amqp.dll was not apparently updated since release 2.2.0, and remains 2.2.0.0

File version is used by Windows Installer and installers based on that technology to determine whether the file on the disk is older than the one within installer package, and therefore needs updating, or not; versioned files are only compared by their file version and some other version characteristics, like language - not by Product Version, or creation date.

While it is kept unchanged, Windows Installer-based installers deploying binaries that consume Microsoft.Azure.Amqp have to resort to workarounds.

image

File version property of the version information is controlled by AssemblyFileVersion attribute.

Could you please consider adding AssemblyFileVersion attribute to src/Properties/Version.cs, and either keeping it in sync with AssemblyVersion (if the latter is increased with each release to nuget) or at least ensuring that the value of AssemblyFileVersion is incremented before each release (and never goes below 2.2.0.0).

Related topics:
AssemblyFileVersion: https://learn.microsoft.com/en-us/troubleshoot/developer/visualstudio/general/assembly-version-assembly-file-version#assemblyfileversion
Windows Installer - file versioning rules: https://learn.microsoft.com/en-us/windows/win32/msi/file-versioning-rules
Windows Installer - determining whether to update a versioned file: https://learn.microsoft.com/en-us/windows/win32/msi/both-files-have-a-version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants