Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_raw_token should take tenant name/id as input #11780

Closed
mit2nil opened this issue Jan 6, 2020 · 3 comments
Closed

get_raw_token should take tenant name/id as input #11780

mit2nil opened this issue Jan 6, 2020 · 3 comments
Assignees
@jiasli
Labels
Core CLI core infrastructure
Milestone
S164

Comments

@mit2nil
Copy link
Member

mit2nil commented Jan 6, 2020

Current interface as shown below takes only subscription and resource as inputs. However, auth token are specific to a tenant and not a subscription. Lack of tenant input also complicates design for scenarios requiring auth token for tenants with no subscription.

def get_raw_token(self, resource=None, subscription=None):
@bim-msft bim-msft added the Core CLI core infrastructure label Jan 6, 2020
@triage-new-issues triage-new-issues bot removed the triage label Jan 6, 2020
@bim-msft
Copy link
Contributor

bim-msft commented Jan 6, 2020

@jiasli Please take a look.

@yonzhan yonzhan added this to the S165 milestone Jan 6, 2020
@mit2nil
Copy link
Member Author

mit2nil commented Jan 7, 2020

add to S165.
@jiasli @yonzhan Is it possible to pull this into S164?

@yonzhan yonzhan modified the milestones: S165, S164 Jan 7, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Jan 7, 2020

@mit2nil add to S164.

@jiasli jiasli mentioned this issue Jan 8, 2020
Merged
2 tasks
@yonzhan yonzhan closed this as completed Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jiasli jiasli

Labels
Core CLI core infrastructure
Projects
None yet
Milestone
S164
Development

No branches or pull requests
4 participants
@bim-msft @jiasli @mit2nil @yonzhan