Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken: az network application-gateway waf-policy managed-rule rule-set add #12387

Closed
PaulCharlton opened this issue Feb 28, 2020 · 2 comments · Fixed by #12518
Closed

broken: az network application-gateway waf-policy managed-rule rule-set add #12387

PaulCharlton opened this issue Feb 28, 2020 · 2 comments · Fixed by #12518
Assignees
Labels
Network az network vnet/lb/nic/dns/etc...
Milestone

Comments

@PaulCharlton
Copy link

PaulCharlton commented Feb 28, 2020

Describe the bug

broken: az network application-gateway waf-policy managed-rule rule-set add --resource-group {rg} --policy-name {policy} --type OWASP --version 3.1 --group-name y --rules x

and ...
az network application-gateway waf-policy managed-rule rule-set add --resource-group {rg} --policy-name {policy} --type OWASP --version 3.1

both of the above forms of the command should work. The AZ CLI mistakenly requires the "group-name" and "rules" arguments. The PowerShell equivalent does not require those two parameters. In the ARM template, those parameters are allowed to be null.

To Reproduce
use: az version
This command is in preview. It may be changed/removed in a future release.
{
"azure-cli": "2.1.0",
"azure-cli-command-modules-nspkg": "2.0.3",
"azure-cli-core": "2.1.0",
"azure-cli-nspkg": "3.0.4",
"azure-cli-telemetry": "1.0.4",
"extensions": {
"interactive": "0.4.3"
}
}

Expected behavior
should behave the same as the Powershell equivalent.

Additional context
Without correct operation, there is no means with the AZ CLI to change the global policy default from "OWASP 3.0" to "OWASP 3.1" other than a raw ARM template.

@PaulCharlton PaulCharlton changed the title broken: az network application-gateway waf-policy managed-rule rule-set add --resource-group {rg} --policy-name {policy} --type OWASP --version 3.1 --group-name y --rules x broken: az network application-gateway waf-policy managed-rule rule-set add Feb 28, 2020
@yonzhan yonzhan added the Network az network vnet/lb/nic/dns/etc... label Feb 28, 2020
@yonzhan yonzhan added this to the S167 milestone Feb 28, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Feb 28, 2020

add to S167.

@jsntcy
Copy link
Member

jsntcy commented Mar 9, 2020

It seems the fix is that we should make the "group-name" and "rules" arguments as optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Network az network vnet/lb/nic/dns/etc...
Projects
None yet
5 participants