Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knack hasn't been republished to make status_tag_messages available to az cli #16703

Closed
scseely opened this issue Jan 28, 2021 · 2 comments
Closed
Assignees
Labels
Core CLI core infrastructure

Comments

@scseely
Copy link

scseely commented Jan 28, 2021

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Describe the bug
After forking and cloning the repo, I tried to do some development. I cannot start the app because of an import of this line: https://github.com/Azure/azure-cli/blob/dev/src/azure-cli-core/azure/cli/core/__init__.py#L45.

Investigating, the functionality which defines knack.util.status_tag_messages was introduced on Dec 16, 2020 but the knack package on PyPi.org has not been updated since July 28, 2020 (https://pypi.org/project/knack/).

To Reproduce
Follow setup instructions, try to run. If you do not have the latest knack, you cannot proceed. Author who introduced the issue is also the maintainer of knack.

Expected behavior
The import should work and code should proceed.

Environment summary
Running on Windows using VS Code and a clean virtual environment (never installing packages into the global libraries for python).

Additional context
Also submitted details to author of the changes (discovered using BLAME).

@ghost ghost added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Jan 28, 2021
@jiasli
Copy link
Member

jiasli commented Jan 28, 2021

The current Azure CLI has a hard dependency on

'knack==0.8.0rc2',

Knack 0.8.0rc2 does have the knack.util.status_tag_messages defined:

https://github.com/microsoft/knack/blob/v0.8.0rc2/knack/util.py#L17-L20

status_tag_messages = {
    'preview': "{} is in preview. It may be changed/removed in a future release.",
    'experimental': "{} is experimental and under development."
}

I believe pip will automatically install Knack 0.8.0rc2 for you whether you are installing the dev Azure CLI using

  • azdev setup, or
  • pip install -e azure-cli azure-cli-core

BTW, we are going to release Knack 0.8.0 very soon (microsoft/knack#231).

@yonzhan yonzhan added the Knack label Jan 28, 2021
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Jan 28, 2021
@yonzhan yonzhan added Core CLI core infrastructure needs-triage This is a new issue that needs to be triaged to the appropriate team. labels Jan 28, 2021
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Jan 28, 2021
@yonzhan yonzhan removed the Knack label Jan 28, 2021
@yonzhan yonzhan added this to the S183 milestone Jan 28, 2021
@scseely
Copy link
Author

scseely commented Jan 28, 2021

Verified that project is able to be debugged in VS Code now. Looks like this isn't a bug. Thank you!

@scseely scseely closed this as completed Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core CLI core infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants