Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webapp] [Discussion] Promote the slot/appsettings command groups up a level #2316

Closed
lostintangent opened this issue Feb 27, 2017 · 3 comments
Assignees

Comments

@lostintangent
Copy link
Member

lostintangent commented Feb 27, 2017

This is somewhat subjective, but I can't help but feel like some of the command groups within the appservice module are unnecessarily deep, and could be potentially simplified a little bit.

One area that I've noticed being a bit "wordy" is working with deployment slots for a web app. For example, to swap two slots, you need to run the following command: az appservice web deployment slot swap, which is quite a mouthful.

I can't help but feel like slots are a valuable enough concept that they could be promoted directly underneath the web group, which would reduce the extra group level (i.e. deployment), and allow typing az appservice web slot swap, which is quite a bit more ergonomic.

Another example of a commonly-used command group, that would potentially be nice to "promote" is appservice web config appsettings. I completely appreciate the logical/semantic grouping of commands, but at the same time, in my usage, I feel like having four levels of command group nesting (for commonly-used features), gets a bit tiresome to use. Could appsettings also be lifted directly underneath web? It feels like that would be helpful, but that could just be me.

The storage module is a good example of a command group that could have been nested more deeply than it is (e.g. both blob and container are top-level groups underneath storage, as opposed to nesting them underneath a more general group for blob-related commands), and the act of flattening groups a little bit makes the overall experience better.

In general, I'd love to see some simplifications of the App service commands, but in particular, it would be great to try to reduce group depth for commonly used commands.

@lostintangent
Copy link
Member Author

In addition to "lifting" the appsettings command group up a level, I'd also like to propose renaming it to env. This not only shortens it (to improve efficiency), but I feel like that is a more idiomatic name for what they represent: environment variables.

@lostintangent
Copy link
Member Author

@yugangw-msft Any updates on this discussion? With #2325 coming (yay!), it would be amazing to flatten some of the other core command groups as well:

az webapp env update
az webapp slot swap

@ahmedelnably ahmedelnably self-assigned this Oct 19, 2017
@panchagnula panchagnula changed the title [App Service] [Discussion] Promote the slot/appsettings command groups up a level [webapp] [Discussion] Promote the slot/appsettings command groups up a level Jun 1, 2018
@yugangw-msft
Copy link
Contributor

After through numerous rounds of discussion & review since last year, i believe we have settled on what we have now. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants