Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression with latest setuptools #23177

Open
jiasli opened this issue Jul 12, 2022 · 5 comments
Open

Performance regression with latest setuptools #23177

jiasli opened this issue Jul 12, 2022 · 5 comments
Assignees
Labels
Azure CLI Team The command of the issue is owned by Azure CLI team Core CLI core infrastructure feature-request
Milestone

Comments

@jiasli
Copy link
Member

jiasli commented Jul 12, 2022

It seems with setuptools 62.6.0 installed, disutils imports setuptools and pkg_resources. This causes some performance regression:

& "C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\python.exe" -m pip list
setuptools             62.6.0

& "C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\python.exe" -X importtime -m azure.cli version 2>perf.log; python -m tuna .\perf.log

image

Originally posted by @jiasli in #7447 (comment)

@jiasli
Copy link
Member Author

jiasli commented Jul 12, 2022

When packaging an MSI

setuptools==52.0.0

is not honored, so the latest setuptools is installed.

@yonzhan yonzhan added the Core CLI core infrastructure label Jul 12, 2022
@yonzhan yonzhan added this to the Jul 2022 (2022-08-02) milestone Jul 12, 2022
@mkrzywanski
Copy link

The new version of cli is completly unusable for me because of this regression. When can we expect this to be fixed? Is the only workaround now to downgrade the azcli?

@jiasli
Copy link
Member Author

jiasli commented Jul 14, 2022

@mkrzywanski,

The new version of cli is completly unusable for me because of this regression.

How do you define "unusable"?

The latest 2.38.0 Azure CLI still only takes acceptable time (~900ms) to execute. This is still must faster than years ago (~2.3s).

> Measure-Command {az version}

Days              : 0
Hours             : 0
Minutes           : 0
Seconds           : 0
Milliseconds      : 911
Ticks             : 9115245
TotalDays         : 1.05500520833333E-05
TotalHours        : 0.00025320125
TotalMinutes      : 0.015192075
TotalSeconds      : 0.9115245
TotalMilliseconds : 911.5245

@mkrzywanski
Copy link

I have already downgraded to previous version that I used (2.31.0) so cannot check but with 2.37.0 and 2.38.0 it took like 5 seconds for me to get a simple secret value from keyvault. Also refreshing state with terraform took like 3 minutes for new azcli versions and with older versions it is blazingly fast.

@jiasli
Copy link
Member Author

jiasli commented Jul 14, 2022

it took like 5 seconds for me to get a simple secret value from keyvault.

Could you share the command you used? We can help verify. @evelyn-ys

refreshing state with terraform took like 3 minutes for new azcli versions and with older versions it is blazingly fast.

You way report this issue to https://github.com/hashicorp/terraform-provider-azurerm instead.

@jiasli jiasli modified the milestones: Jul 2022 (2022-08-02), Backlog Jul 14, 2022
@yonzhan yonzhan added feature-request Azure CLI Team The command of the issue is owned by Azure CLI team labels Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure CLI Team The command of the issue is owned by Azure CLI team Core CLI core infrastructure feature-request
Projects
None yet
Development

No branches or pull requests

3 participants