Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extensions] "Blessed" Extensions should not trigger warnings when overriding existing commands #4712

Closed
tjprescott opened this issue Oct 18, 2017 · 7 comments
Assignees
Labels
Discussion Extensions `az extension` commands or extension infrastructure
Milestone

Comments

@tjprescott
Copy link
Member

As discussed via email, official or "blessed" extensions should suppress the warning about overriding the default implementation.

@tjprescott tjprescott added Extensions `az extension` commands or extension infrastructure Feature labels Oct 18, 2017
@digimaun
Copy link
Member

Thanks for creating the issue we discussed @tjprescott. The IoT extension can be a guinea pig for blessing criteria.

@troydai
Copy link
Contributor

troydai commented Oct 19, 2017

The difficulty of assigning an extension the 'blessed' status is that there is no way to verify the identity of an extension. We don't sign the extension.

@derekbekoe
Copy link
Member

With an extension index, we could have control over such blessed extensions.

@JasonRShaver
Copy link
Contributor

Currently this is by design, especially given the relative scope of extensions. As the CLI grows, we'll revisit this to setup some healthy and secure patterns here. If you have any user data or complains, please share with us to help us prioritize.

@jongio
Copy link
Member

jongio commented Oct 30, 2018

@johanste - The message is pretty intimidating and for the IoT extension, we'd like to have something more friendly or nothing at all. Can we revisit this?

@tjprescott tjprescott reopened this Oct 30, 2018
@tjprescott tjprescott assigned tjprescott and unassigned williexu Mar 26, 2019
@tjprescott tjprescott removed their assignment Jul 29, 2019
@haroldrandom haroldrandom added Discussion Extensions `az extension` commands or extension infrastructure Feature labels Oct 25, 2019
@yonzhan yonzhan assigned haroldrandom and jsntcy and unassigned haroldrandom Dec 23, 2019
@yonzhan yonzhan added this to the S165 milestone Dec 23, 2019
@yonzhan
Copy link
Collaborator

yonzhan commented Dec 23, 2019

add to S165.

@yonzhan yonzhan modified the milestones: S165, S166 Feb 15, 2020
@yonzhan yonzhan modified the milestones: S166, S167 Mar 5, 2020
@jiasli
Copy link
Member

jiasli commented Mar 26, 2020

We have added option --only-show-errors in #12604 to disable warnings that are written to stderr. It will be included in S167 release.

@jiasli jiasli closed this as completed Mar 26, 2020
@jiasli jiasli self-assigned this Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Extensions `az extension` commands or extension infrastructure
Projects
None yet
Development

No branches or pull requests