Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OperationCancelledException and TaskCancelledException improvements #1200

Closed
j82w opened this issue Feb 6, 2020 · 1 comment
Closed

OperationCancelledException and TaskCancelledException improvements #1200

j82w opened this issue Feb 6, 2020 · 1 comment

Comments

@j82w
Copy link
Contributor

j82w commented Feb 6, 2020

OperationCancelledException and TaskCancelledException should only be thrown for user cancelled events. SDK cancellations should use a CosmosException.

OperationCancelledException and TaskCancelledException should be extended to handle diagnostics. The extended types can be casted back down but add the diagnostic to the ToString(). Throwing the operation cancelled exception without diagnostics makes it difficult to debug.
@j82w
Copy link
Contributor Author

j82w commented Mar 26, 2021

Fixed in #1550

@j82w j82w closed this as completed Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@j82w