Microsoft/Consumption cannot toggle thresholdType in budgets

[stephybun]

As of 15.03.2021 thresholdType can accept the values Actual and Forecasted, but it doesn't seem possible to toggle between the two with API calls.

Here is our HTTP PUT Request after we created a budget with thresholdType = Forecasted

PUT https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Consumption/budgets/swacctestbudget-30921?api-version=2019-10-01

{
  "properties": {
    "amount": "3000",
    "category": "Cost",
    "filter": {},
    "notifications": {
      "actual_GreaterThan_95_Percent": {
        "enabled": true,
        "operator": "GreaterThan",
        "threshold": "95",
        "contactEmails": [
          "[email protected]"
        ],
        "contactRoles": [],
        "contactGroups": [],
        "thresholdType": "Actual"
      }
    },
    "timeGrain": "Monthly",
    "timePeriod": {
      "startDate": "2021-09-01T00:00:00Z",
      "endDate": "2022-10-01T00:00:00Z"
    }
  }
}

And we receive a 200 with the following response

{
    "id": "/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Consumption/budgets/swacctestbudget-30921",
    "name": "swacctestbudget-30921",
    "type": "Microsoft.Consumption/budgets",
    "eTag": "\"1d7b5ed4fab3297\"",
    "properties": {
        "timePeriod": {
            "startDate": "2021-09-01T00:00:00Z",
            "endDate": "2022-10-01T00:00:00Z"
        },
        "timeGrain": "Monthly",
        "amount": 3000.0,
        "currentSpend": null,
        "category": "Cost",
        "notifications": {
            "actual_GreaterThan_95_Percent": {
                "enabled": true,
                "operator": "GreaterThan",
                "threshold": 95.00,
                "contactEmails": [
                    "[email protected]"
                ],
                "contactRoles": [],
                "contactGroups": [],
                "thresholdType": "Forecasted"
            }
        },
        "filter": {}
    }
}

In addition the Swagger Spec for thresholdType only lists Actual even though Forecasted is still accepted:

azure-rest-api-specs/specification/consumption/resource-manager/Microsoft.Consumption/stable/2019-10-01/consumption.json

Lines 4158 to 4169 in fd7603f

	"thresholdType": {
	"description": "The type of threshold",
	"type": "string",
	"enum": [
	"Actual"
	],
	"x-ms-enum": {
	"name": "ThresholdType",
	"modelAsString": true
	},
	"default": "Actual"
	},

[ghost]

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @ms-premp.

Issue Details

---

As of 15.03.2021 thresholdType can accept the values Actual and Forecasted, but it doesn't seem possible to toggle between the two with API calls.

Here is our HTTP PUT Request after we created a budget with thresholdType = Forecasted

PUT https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Consumption/budgets/swacctestbudget-30921?api-version=2019-10-01

{
  "properties": {
    "amount": "3000",
    "category": "Cost",
    "filter": {},
    "notifications": {
      "actual_GreaterThan_95_Percent": {
        "enabled": true,
        "operator": "GreaterThan",
        "threshold": "95",
        "contactEmails": [
          "[email protected]"
        ],
        "contactRoles": [],
        "contactGroups": [],
        "thresholdType": "Actual"
      }
    },
    "timeGrain": "Monthly",
    "timePeriod": {
      "startDate": "2021-09-01T00:00:00Z",
      "endDate": "2022-10-01T00:00:00Z"
    }
  }
}

And we receive a 200 with the following response

{
    "id": "/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Consumption/budgets/swacctestbudget-30921",
    "name": "swacctestbudget-30921",
    "type": "Microsoft.Consumption/budgets",
    "eTag": "\"1d7b5ed4fab3297\"",
    "properties": {
        "timePeriod": {
            "startDate": "2021-09-01T00:00:00Z",
            "endDate": "2022-10-01T00:00:00Z"
        },
        "timeGrain": "Monthly",
        "amount": 3000.0,
        "currentSpend": null,
        "category": "Cost",
        "notifications": {
            "actual_GreaterThan_95_Percent": {
                "enabled": true,
                "operator": "GreaterThan",
                "threshold": 95.00,
                "contactEmails": [
                    "[email protected]"
                ],
                "contactRoles": [],
                "contactGroups": [],
                "thresholdType": "Forecasted"
            }
        },
        "filter": {}
    }
}

In addition the Swagger Spec for thresholdType only lists Actual even though Forecasted is still accepted:

azure-rest-api-specs/specification/consumption/resource-manager/Microsoft.Consumption/stable/2019-10-01/consumption.json

Lines 4158 to 4169 in fd7603f

	"thresholdType": {
	"description": "The type of threshold",
	"type": "string",
	"enum": [
	"Actual"
	],
	"x-ms-enum": {
	"name": "ThresholdType",
	"modelAsString": true
	},
	"default": "Actual"
	},

Author:	stephybun
Assignees:	jianyexi
Labels:	question, Consumption, Service Attention, customer-reported, needs-triage
Milestone:	-

[ccmaxpcrew]

We are presently investigating this.

[ccmaxpcrew]

Hi @stephybun. From the request body, I noticed the notification name as "actual_GreaterThan_95_Percent". Was this name different from the previous notification name? As long as new name is different from the previous notification name, it should work. Let us know if you are noticing a different behavior.