-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data Factory] set computeType, coreCount to object type to allow expressions #10897
[Data Factory] set computeType, coreCount to object type to allow expressions #10897
Conversation
[Staging] Swagger Validation Report
❌ |
Rule | Message |
---|---|
1026 - TypeChanged |
The new version has a different type 'object' than the previous one 'string'. New: stable/2018-06-01/entityTypes/Pipeline.json#L6837:13 Old: stable/2018-06-01/entityTypes/Pipeline.json#L6837:13 |
1026 - TypeChanged |
The new version has a different type 'object' than the previous one 'integer'. New: stable/2018-06-01/entityTypes/Pipeline.json#L6841:13 Old: stable/2018-06-01/entityTypes/Pipeline.json#L6850:13 |
1026 - TypeChanged |
The new version has a different type 'object' than the previous one 'string'. New: stable/2018-06-01/entityTypes/Pipeline.json#L6837:13 Old: stable/2018-06-01/entityTypes/Pipeline.json#L6837:13 |
1026 - TypeChanged |
The new version has a different type 'object' than the previous one 'integer'. New: stable/2018-06-01/entityTypes/Pipeline.json#L6841:13 Old: stable/2018-06-01/entityTypes/Pipeline.json#L6850:13 |
️️✔️
LintDiff [Detail]
️✔️
Validation passes for LintDiff.
️️✔️
Avocado [Detail]
️✔️
Validation passes for Avocado.
️️✔️
ModelValidation [Detail]
️✔️
Validation passes for ModelValidation.
️️✔️
SemanticValidation [Detail]
️✔️
Validation passes for SemanticValidation.
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python - Release
|
Azure CLI Extension Generation - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-go - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
We would like to support both object and string type for |
@qianwens could you please review this change? |
@@ -6835,21 +6835,12 @@ | |||
"type": "object", | |||
"properties": { | |||
"computeType": { | |||
"description": "Compute type of the cluster which will execute data flow job.", | |||
"type": "string", | |||
"enum": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would cause breaking change in SDK. Please request an approval from API Review Board as defined in the Breaking Change Policy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qianwens This is actually a bug that we are trying to fix. I agree that customers may have to update their code if they are relying on the string data type for these two properties, and the change required would be a simple cast to string type. But this is still a bug and we are not able to support expressions for these two properties as they are currently modeled as string. Also, we do have some customers waiting on the expression support. Given this, do we still need to get approval from API Review Board?
azure-resource-manager-schemas - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
…#10897) Co-authored-by: Bhaskar Annamalai <[email protected]>
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.