Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Factory] set computeType, coreCount to object type to allow expressions #10897

Merged
merged 1 commit into from
Nov 5, 2020
Merged

[Data Factory] set computeType, coreCount to object type to allow expressions #10897

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions ...actory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6835,21 +6835,12 @@
"type": "object",
"properties": {
"computeType": {
"description": "Compute type of the cluster which will execute data flow job.",
"type": "string",
"enum": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would cause breaking change in SDK. Please request an approval from API Review Board as defined in the Breaking Change Policy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qianwens This is actually a bug that we are trying to fix. I agree that customers may have to update their code if they are relying on the string data type for these two properties, and the change required would be a simple cast to string type. But this is still a bug and we are not able to support expressions for these two properties as they are currently modeled as string. Also, we do have some customers waiting on the expression support. Given this, do we still need to get approval from API Review Board?

"General",
"MemoryOptimized",
"ComputeOptimized"
],
"x-ms-enum": {
"name": "DataFlowComputeType",
"modelAsString": true
}
"description": "Compute type of the cluster which will execute data flow job. Possible values include: 'General', 'MemoryOptimized', 'ComputeOptimized'. Type: string (or Expression with resultType string)",
"type": "object"
},
"coreCount": {
"description": "Core count of the cluster which will execute data flow job. Supported values are: 8, 16, 32, 48, 80, 144 and 272.",
"type": "integer"
"description": "Core count of the cluster which will execute data flow job. Supported values are: 8, 16, 32, 48, 80, 144 and 272. Type: integer (or Expression with resultType integer)",
"type": "object"
}
}
}
Expand Down