Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Devices to add version preview/2020-09-01-preview #11809

Merged
merged 6 commits into from
Dec 12, 2020
+64 −3
Merged

[Hub Generated] Review request for Microsoft.Devices to add version preview/2020-09-01-preview #11809

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
59d5e39
Support userassigned identities for the KEK
mrohera Nov 25, 2020
913c77f
Address PR comments
mrohera Nov 25, 2020
8d6108c
Update rev for breaking changes
mrohera Dec 1, 2020
46d9c90
Add identity information to the DPS description
mrohera Dec 4, 2020
431b62f
Revert back version
mrohera Dec 4, 2020
ecdb59a
Lint warnings
mrohera Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions ...sioningservices/resource-manager/Microsoft.Devices/preview/2020-09-01-preview/iotdps.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"swagger": "2.0",
"info": {
"version": "2020-09-01-preview",
"version": "2020-09-01-preview.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it valid to change version like this?
cc: @akning-ms

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was given f/b that this is the guideline in order to make changes to an API that is still in development. I am checking with the approver and sharing the failure seen below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed this version change since I added more changes and wanted the validations to re-run. I do not have clarity on what direction to proceed since the tests fail if this requirement were to be enforced.

"x-ms-code-generation-settings": {
"host": "management.azure.com"
},
Expand Down Expand Up @@ -1921,19 +1921,23 @@
]
},
"EncryptionPropertiesDescription": {
"description": "The encryption properties for the IoT DPS instance.",
"description": "The customer-managed encryption key (CMK) properties for the IoT DPS instance.",
"type": "object",
"properties": {
"keySource": {
"description": "The source of the key.",
"description": "The source of the encryption key. Typically, Microsoft.KeyVault",
"type": "string"
},
"keyVaultProperties": {
"description": "The properties of the KeyVault key.",
"description": "The properties of the encryption key configured in KeyVault.",
"type": "array",
"items": {
"$ref": "#/definitions/KeyVaultKeyProperties"
}
},
"identity": {
"description": "The identity used to access the encryption key in KeyVault.",
"$ref": "#/definitions/EncryptionKeyIdentity"
}
}
},
Expand All @@ -1947,6 +1951,16 @@
}
}
},
"EncryptionKeyIdentity": {
"description": "The properties of the identity used to access the key encryption key in KeyVault.",
"type": "object",
"properties": {
"userAssignedIdentity": {
"type": "string",
"description": "The user assigned identity."
}
}
},
"IpFilterRule": {
"description": "The IP filter rules for a provisioning Service.",
"type": "object",
Expand Down