-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.Devices to add version preview/2020-09-01-preview #12036
Conversation
…-01-preview to version 2020-09-01-preview.1
Swagger Validation Report
|
Rule | Message |
---|---|
AutoRest Exception |
"details":" "Channel": "fatal", "Text": "swagger-document/compose - FAILED" "Channel": "fatal", "Text": "Error: '$.paths[\"/providers/Microsoft.Devices/operations\"].get[\"x-ms-examples\"].DPSOperations.parameters[\"api-version\"]' has incompatible values (---\n2020-09-01-preview.1\n, ---\n2020-09-01-preview\n)."(node:6131) UnhandledPromiseRejectionWarning: Error: '$.paths["/providers/Microsoft.Devices/operations"].get["x-ms-examples"].DPSOperations.parameters["api-version"]' has incompatible values (---2020-09-01-preview.1", "location":"https://github.com/Azure/azure-rest-api-specs/blob/142d1081a79b733c0c9acd7f2ff5db27057cd3f4/specification/deviceprovisioningservices/resource-manager/readme.md" |
️❌
Avocado: 25 Errors, 0 Warnings failed [Detail]
Only 10 items are listed, please refer to log for more details.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.8.1)
- original: preview/2020-09-01-preview/iotdps.json <---> new: preview/2020-09-01-preview.1/iotdps.json
️️✔️
[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.8.1)
- original: stable/2020-03-01/iotdps.json <---> new: preview/2020-09-01-preview.1/iotdps.json
Swagger Generation Artifacts
|
Hi, @mrohera your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @raych1 |
@akning-ms copying you here since you have context. |
Hi, @mrohera Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
@mrohera , could you fix the CI check failures? Please starts from |
@akning-ms are these errors due to the recommended versioning pattern that is not supported? |
No, it is due to your PR still change for /preview/2020-09-01-preview/iotdps.json. it should be /preview/2020-09-01-preview.1/iotdps.json |
Thanks @akning-ms, I've fixed it. I accidentally updated the wrong file. |
@akning-ms please have a look now and let me know if these failures are expected? |
The avocado error is still there, you need to also remove /preview/2020-09-01-preview/iotdps.json from PR to fix it. |
ARM review is not required as it is just add optional properties as this PR #11809 |
Looks ARM still not support new version format which still in progress. The PR will hold until ARM support. will update this in breaking change intake form. |
Hi, @mrohera. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Closing PR since this style of API versioning is unsupported. |
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.