Add Microsoft.PolicyInsights/attestations API #12661

pilor · 2021-01-27T00:27:25Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet. February 2021
When you expect to publish swagger? Please provide date, or month to public if date is not available yet. February 2021
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-01-27T00:27:28Z

Hi, @pilor Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2021-01-27T00:27:29Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- policyinsights/resource-manager/readme.md tag:package-2021-01
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- policyinsights/resource-manager/readme.md tag:default

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/policyinsights/resource-manager/readme.md tag: specification/policyinsights/resource-manager/readme.md#tag-package-2021-01

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-01-27T00:27:29Z

Hi, @pilor your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @

openapi-pipeline-app · 2021-01-27T00:27:30Z

Swagger Generation Artifacts

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from b8daa04. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/[email protected] --version=3.0.6351 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/policyinsights/resource-manager/readme.md

️✔️policyinsights [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] npm WARN [email protected] No repository field.
cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from b8daa04. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/policyinsights/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.PolicyInsights [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.PolicyInsights.4.0.0.nupkg
- Microsoft.Azure.Management.PolicyInsights.4.0.0.snupkg

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from b8daa04. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️policyinsights/mgmt/2018-04-04/policyinsights [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/policyinsights/mgmt/2021-01-01-preview/policyinsights [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
```
️✔️preview/policyinsights/mgmt/2020-07-01-preview/policyinsights [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/policyinsights/mgmt/2019-10-01-preview/policyinsights [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/policyinsights/mgmt/2018-07-01-preview/policyinsights [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from b8daa04. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/policyinsights/resource-manager/readme.md

️✔️@azure/arm-policyinsights [View full logs] [Release SDK Changes]

azure-arm-policyinsights-4.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/policyInsightsClient.js → ./dist/arm-policyinsights.js...
cmderr	[npmPack] created ./dist/arm-policyinsights.js in 565ms

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from b8daa04. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
cmderr	[automation_init.sh]   Failed building wheel for wrapt
cmderr	[automation_init.sh]   Failed building wheel for yarl
cmderr	[automation_init.sh]   Failed building wheel for multidict
cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-policyinsights [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model ExpressionEvaluationDetails has a new parameter expression_kind
info	[Changelog]   - Added operation group PolicyRestrictionsOperations
info	[Changelog]   - Added operation group AttestationsOperations

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from b8daa04. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-01-28 03:40:17 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-policyinsights"
cmderr	[generate.py] 2021-01-28 03:40:17 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-01-28 03:40:17 INFO autorest --version=3.0.6350 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/policyinsights/azure-resourcemanager-policyinsights --java.namespace=com.azure.resourcemanager.policyinsights   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/policyinsights/resource-manager/readme.md
cmderr	[generate.py] 2021-01-28 03:41:13 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-01-28 03:41:13 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-01-28 03:41:13 INFO [POM][Skip] pom already has module azure-resourcemanager-policyinsights
cmderr	[generate.py] 2021-01-28 03:41:13 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-01-28 03:41:13 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-01-28 03:41:13 INFO [POM][Success] Write to root pom
cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release

️✔️azure-resourcemanager-policyinsights [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-01-28 03:44:43 DEBUG Got artifact_id: azure-resourcemanager-policyinsights
cmderr	[Inst] 2021-01-28 03:44:43 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-01-28 03:44:43 DEBUG Got artifact: azure-resourcemanager-policyinsights-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-28 03:44:43 DEBUG Match jar package: azure-resourcemanager-policyinsights-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-28 03:44:43 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12661/azure-sdk-for-java/azure-resourcemanager-policyinsights/azure-resourcemanager-policyinsights-1.0.0-beta.1.jar\" -o azure-resourcemanager-policyinsights-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-policyinsights -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-policyinsights-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

pilor · 2021-01-27T00:28:18Z

This spec was ARM reviewed in an older PR that was abandoned due to us not being ready to go public. There are no API differences between then and now. #9844

openapi-workflow-bot · 2021-01-27T00:29:08Z

Hi @pilor, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

xseeseesee · 2021-01-27T06:24:35Z

@pilor The code owner of policyinsights seems out-dated. Do you know any team member could help review from service end?

pilor · 2021-01-27T21:55:33Z

@pilor The code owner of policyinsights seems out-dated. Do you know any team member could help review from service end?

Good catch. Done.

xseeseesee · 2021-01-28T03:23:27Z

@pilor Please let me know if it is ready to merge. Thanks.

pilor · 2021-01-28T03:34:22Z

@pilor Please let me know if it is ready to merge. Thanks.

Yes it is, please do

* Attestations API * Update definitionReferenceId description * Update owner description * Update readmes with new tag * Move to 2021-01-01 * Update api-version * Update owners

pilor added 5 commits January 26, 2021 16:01

Attestations API

666273a

Update definitionReferenceId description

ed8c59c

Update owner description

0c653cc

Update readmes with new tag

88a7ea0

Move to 2021-01-01

addb2ae

pilor requested a review from ArcturusZhang as a code owner January 27, 2021 00:27

openapi-assignment-bot bot assigned xseeseesee Jan 27, 2021

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 27, 2021

pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 27, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Jan 27, 2021

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Jan 27, 2021

openapi-sdkautomation bot mentioned this pull request Jan 27, 2021

[AutoPR @azure/arm-policyinsights] Add Microsoft.PolicyInsights/attestations API AzureSDKAutomation/azure-sdk-for-js#3408

Closed

Update api-version

3fe459c

Update owners

7dd4b92

xseeseesee approved these changes Jan 28, 2021

View reviewed changes

xseeseesee merged commit b8daa04 into Azure:master Jan 28, 2021

eladperets mentioned this pull request Nov 12, 2021

Update Microsoft.PolicyInsights .NET SDK Azure/azure-sdk-for-net#25309

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Microsoft.PolicyInsights/attestations API #12661

Add Microsoft.PolicyInsights/attestations API #12661

pilor commented Jan 27, 2021

openapi-workflow-bot bot commented Jan 27, 2021

openapi-pipeline-app bot commented Jan 27, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 27, 2021

openapi-pipeline-app bot commented Jan 27, 2021 •

edited

Loading

pilor commented Jan 27, 2021

openapi-workflow-bot bot commented Jan 27, 2021

xseeseesee commented Jan 27, 2021

pilor commented Jan 27, 2021

xseeseesee commented Jan 28, 2021

pilor commented Jan 28, 2021

Add Microsoft.PolicyInsights/attestations API #12661

Add Microsoft.PolicyInsights/attestations API #12661

Conversation

pilor commented Jan 27, 2021

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jan 27, 2021

openapi-pipeline-app bot commented Jan 27, 2021 • edited Loading

Swagger Validation Report

openapi-workflow-bot bot commented Jan 27, 2021

openapi-pipeline-app bot commented Jan 27, 2021 • edited Loading

Swagger Generation Artifacts

pilor commented Jan 27, 2021

openapi-workflow-bot bot commented Jan 27, 2021

xseeseesee commented Jan 27, 2021

pilor commented Jan 27, 2021

xseeseesee commented Jan 28, 2021

pilor commented Jan 28, 2021

openapi-pipeline-app bot commented Jan 27, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 27, 2021 •

edited

Loading