[Hub Generated] Review request for Microsoft.BotService to add version preview/2021-05-01 #14225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @swagatmishra2007 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Based on the response model schema, operation 'PrivateLinkResources_ListByBotResource' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1379 |
|
| The child tracked resource, 'privateEndpointConnections' with immediate parent 'Bot', must have a list by immediate parent operation. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1422 |
|
| The resource 'PrivateLinkResource' does not have get operation, please add it. Location: Microsoft.BotService/preview/2021-05-01-preview/privatelinks.json#L121 |
The following errors/warnings exist before current PR submission:
Only 10 items are listed, please refer to log for more details.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 18 Errors, 0 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.8.9)
- current:preview/2021-05-01-preview/botservice.json compared with base:preview/2018-07-12/botservice.json
- current:preview/2021-05-01-preview/botservice.json compared with base:stable/2021-03-01/botservice.json
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.BotService/botServices/{resourceName}/Connections/{connectionName}/listWithSecrets' removed or restructured? Old: Microsoft.BotService/preview/2018-07-12/botservice.json#L722:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.BotService/botServices/{resourceName}/Connections/{connectionName}' removed or restructured? Old: Microsoft.BotService/preview/2018-07-12/botservice.json#L767:5 |
|
The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.BotService/checkEnterpriseChannelNameAvailability' removed or restructured? Old: Microsoft.BotService/preview/2018-07-12/botservice.json#L1016:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.BotService/enterpriseChannels' removed or restructured? Old: Microsoft.BotService/preview/2018-07-12/botservice.json#L1058:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.BotService/enterpriseChannels/{resourceName}' removed or restructured? Old: Microsoft.BotService/preview/2018-07-12/botservice.json#L1100:5 |
|
The new version is missing a definition that was found in the old version. Was 'EnterpriseChannelCheckNameAvailabilityRequest' removed or renamed? New: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1422:3 Old: Microsoft.BotService/preview/2018-07-12/botservice.json#L1306:3 |
|
The new version is missing a definition that was found in the old version. Was 'EnterpriseChannel' removed or renamed? New: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1422:3 Old: Microsoft.BotService/preview/2018-07-12/botservice.json#L1306:3 |
|
The new version is missing a definition that was found in the old version. Was 'EnterpriseChannelProperties' removed or renamed? New: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1422:3 Old: Microsoft.BotService/preview/2018-07-12/botservice.json#L1306:3 |
|
The new version adds a response code 'default'. New: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L766:11 |
|
The new version has a different 'pattern' value than the previous one. New: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2873:5 Old: Microsoft.BotService/preview/2018-07-12/botservice.json#L2607:5 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"botservice/resource-manager/readme.md",
"tag":"package-preview-2021-05",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"botservice/resource-manager/readme.md",
"tag":"package-preview-2021-05",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"botservice/resource-manager/readme.md",
"tag":"package-preview-2021-05",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=218738&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️❌[Staging] SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-python-track2 - track2_azure-mgmt-botservice - 1.0.0+ Model DirectLineSpeechChannelProperties has a new required parameter cognitive_service_region + Model DirectLineSpeechChannelProperties has a new required parameter cognitive_service_subscription_key + Model DirectLineSpeechChannelProperties no longer has parameter cognitive_services_subscription_id
️❌ azure-sdk-for-net failed [Detail]
warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-5.0 command autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/botservice/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
❌Microsoft.Azure.Management.BotService [View full logs] [Release SDK Changes]cmdout [msbuild] 2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj] cmdout [msbuild] 2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj] cmdout [msbuild] 2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj] cmdout [msbuild] 2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj] cmdout [msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj] cmdout [msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj] cmdout [msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj] cmdout [msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj] error Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet
️⚠️ azure-sdk-for-python warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. cmderr [automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible. cmderr [automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. cmderr [automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible. cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️azure-mgmt-botservice [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Model BotProperties has a new parameter schema_transformation_version info [Changelog] - Model BotProperties has a new parameter is_isolated info [Changelog] - Added operation group OperationResultsOperations info [Changelog] - Added operation group PrivateEndpointConnectionsOperations info [Changelog] - Added operation group HostSettingsOperations info [Changelog] - Added operation group PrivateLinkResourcesOperations info [Changelog] info [Changelog] **Breaking changes** info [Changelog] info [Changelog] - Model DirectLineSpeechChannelProperties no longer has parameter cognitive_services_subscription_id info [Changelog] - Model DirectLineSpeechChannelProperties has a new required parameter cognitive_service_subscription_key info [Changelog] - Model DirectLineSpeechChannelProperties has a new required parameter cognitive_service_region
️⚠️ azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️track2_azure-mgmt-botservice [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Added operation group PrivateEndpointConnectionsOperations info [Changelog] - Added operation group PrivateLinkResourcesOperations info [Changelog] - Added operation group OperationResultsOperations info [Changelog] info [Changelog] **Breaking changes** info [Changelog] info [Changelog] - Model DirectLineSpeechChannelProperties no longer has parameter cognitive_services_subscription_id info [Changelog] - Model DirectLineSpeechChannelProperties has a new required parameter cognitive_service_region info [Changelog] - Model DirectLineSpeechChannelProperties has a new required parameter cognitive_service_subscription_key
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
- Only show 40 items here, please refer to log for details.
️✔️botservice/mgmt/2021-03-01/botservice [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] - Const `ChannelNameBasicChannelChannelNameDirectLineSpeechChannel` has been removed info [Changelog] - Const `SkuTierStandard` has been removed info [Changelog] - Const `ChannelNameBasicChannelChannelNameTelegramChannel` has been removed info [Changelog] - Const `ChannelNameBasicChannelChannelNameKikChannel` has been removed info [Changelog] - Const `ChannelNameBasicChannelChannelNameAlexaChannel` has been removed info [Changelog] - Const `ChannelNameBasicChannelChannelNameLineChannel` has been removed info [Changelog] - Const `ChannelNameBasicChannelChannelNameSlackChannel` has been removed info [Changelog] - Const `ChannelNameBasicChannelChannelNameDirectLineChannel` has been removed info [Changelog] - Const `ChannelNameBasicChannelChannelNameSmsChannel` has been removed info [Changelog] - Const `ChannelNameBasicChannelChannelNameFacebookChannel` has been removed info [Changelog] - Const `ChannelNameBasicChannelChannelNameWebChatChannel` has been removed info [Changelog] - Const `SkuNameF0` has been removed info [Changelog] - Const `SkuNameS1` has been removed info [Changelog] - Const `ChannelNameBasicChannelChannelNameChannel` has been removed info [Changelog] - Function `ServiceProviderParameter.MarshalJSON` has been removed info [Changelog] - Function `ConnectionItemName.MarshalJSON` has been removed info [Changelog] info [Changelog] ### New Content info [Changelog] info [Changelog] - New const `Free` info [Changelog] - New const `ChannelNameAlexaChannel1` info [Changelog] - New const `ChannelNameSlackChannel1` info [Changelog] - New const `Standard` info [Changelog] - New const `ChannelNameWebChatChannel1` info [Changelog] - New const `ChannelNameChannel` info [Changelog] - New const `ChannelNameDirectLineChannel1` info [Changelog] - New const `ChannelNameEmailChannel1` info [Changelog] - New const `ChannelNameKikChannel1` info [Changelog] - New const `S1` info [Changelog] - New const `ChannelNameTelegramChannel1` info [Changelog] - New const `ChannelNameSkypeChannel1` info [Changelog] - New const `ChannelNameFacebookChannel1` info [Changelog] - New const `ChannelNameSmsChannel1` info [Changelog] - New const `ChannelNameMsTeamsChannel1` info [Changelog] - New const `ChannelNameDirectLineSpeechChannel1` info [Changelog] - New const `F0` info [Changelog] - New const `ChannelNameLineChannel1` info [Changelog] info [Changelog] Total 20 breaking change(s), 18 additive change(s). info [Changelog]
️✔️preview/botservice/mgmt/2018-07-12/botservice [View full logs] [Release SDK Changes]info [Changelog] No exported changes
️✔️preview/botservice/mgmt/2017-12-01/botservice [View full logs] [Release SDK Changes]info [Changelog] No exported changes
️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️botservice [View full logs] [Release Schema Changes]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
warn Skip initScript due to not configured command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/botservice/resource-manager/readme.md
️✔️@azure/arm-botservice [View full logs] [Release SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/azureBotService.js → ./dist/arm-botservice.js... cmderr [npmPack] created ./dist/arm-botservice.js in 352ms
|
Hi @swagatmishra2007, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
Changes in this PR-
|
This was referenced May 4, 2021
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
swagatmishra2007
added
the
WaitForARMFeedback
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jianyexi
reviewed
May 20, 2021
Co-authored-by: JianyeXi <[email protected]>
|
@swagatmishra2007 , |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
No breaking change compared with the latest version. |
lirenhe
approved these changes
May 26, 2021
This was referenced May 26, 2021
swagatmishra2007
deleted the
dev-botservice-Microsoft.BotService-2021-05-01
branch
This was referenced May 26, 2021
Closed
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…n preview/2021-05-01 (Azure#14225) * Adds base for updating Microsoft.BotService from version stable/2021-03-01 to version 2021-05-01 * Updates readme * Updates API version in new specs and examples * add operation result api's to support async operations * add private links support * fix issues in examples * fix more errors * fix prettier issues * add missing private links operation. some more fixes * fix model validation errors * address comments * remove properties bag * remove unintentional change in unrelated api * update example * change api version to have preview suffix * fix lint and model validation errors * change folder name to preview to match api version * add breaking changes from base branch * fix api version * fix prettier warnings * update readme * Update specification/botservice/resource-manager/readme.md Co-authored-by: JianyeXi <[email protected]> * check if rename works * remove system data since it's not support for other botservice * remove references to common types.json resource to avoid conflicts Co-authored-by: Swagat Mishra <[email protected]> Co-authored-by: JianyeXi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
We are targeting to be in public preview by July for private links (which are the new api's added in this new APIVersion
The swagger would be published (as public preview) in june. We expect to go to a stable version a month after that
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.