Mitryakh/network march #15709
Merged
Mitryakh/network march #15709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…01 to version 2021-03-01
…tualWan VpnGateway (#14462)
Co-authored-by: Abhishek Shah <[email protected]>
* Add PL ASG * Prettier
…01 (#14662) * Ipconfigurations swagger * Ran prettier check * fixing conflicting files * fixing lint * Fixing linter diff * Lint diff * resolving comments * fixing conflict * Fioxing * running prettier * Fixing linter comment Co-authored-by: Shane Baden <[email protected]>
* Add missing 'type' and 'serviceAlias' for ServiceEndpointPolicy related API response * Add missing 'contextualServiceEndpointPolicies' * fix bug * fix type * Add missing properties to ServiceEndpointPolicy * Revert "fix type" This reverts commit 3a49beb. * Revert "fix bug" This reverts commit a4fff4a. * Revert "Add missing 'contextualServiceEndpointPolicies'" This reverts commit ccf1916. * Revert "Add missing 'type' and 'serviceAlias' for ServiceEndpointPolicy related API response" This reverts commit e532cc1. Co-authored-by: Xu Wang <[email protected]>
* add new service tag details api * prettier check fixes * fixing lint issue, additional properties issue
* add Load distribution policy and global configuration to Application Gateway resource * prettify * remove provisioning state
* changes needed for BgpEndpoint * prettier check * model validation fix * fix description * update again
* Updating the DSCP jsons to reflect the multi-qos support * Adding support to multi-qos * adding the type object to NrpQos * fixing the prettier removing my update to the settings * fixing the missing type object error. seeing if this also fixes the additional attributes exception * fixing the prettier exception * almost forgot this, it was refactor from NrpQos to QosDefinition. NRPQos is already being used in Networking repo * copying what I did with my other objects * names didn't match with what I have in NRP's src * forgot to update the examples with the updates in the specification. updating it * fixing the merge exceptions
* Add SQL Setting to Firewall Policy * fix lint check except for object type * resolve linter error
…source properties in applicationGateways.json (#15318) * fix: change target to an array and add subresource properties * fix target examples
* Initial commit * Validation fixes * Update bastionHost.json Co-authored-by: Abhishek Shah <[email protected]>
* explicit proxy swagger change * prettier check fix * lint check * prettier fix * revert unnecessary file change
Co-authored-by: Shane Baden <[email protected]>
|
Hi, @MikhailTryakhov Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=249153&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️❌[Staging] SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-network - 19.0.0️✔️azure-sdk-for-go - network/mgmt/2021-02-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2020-11-01/network - v56.3.0❌azure-sdk-for-go - network/mgmt/2020-08-01/network - v56.3.0+ Field `ExtendedLocation` of struct `VirtualNetworkGatewayPropertiesFormat` has been removed + Field `VirtualNetworkExtendedLocationResourceID` of struct `VirtualNetworkGatewayPropertiesFormat` has been removed + Type of `SubnetPropertiesFormat.PrivateEndpointNetworkPolicies` has been changed from `*string` to `VirtualNetworkPrivateEndpointNetworkPolicies` + Type of `SubnetPropertiesFormat.PrivateLinkServiceNetworkPolicies` has been changed from `*string` to `VirtualNetworkPrivateLinkServiceNetworkPolicies`
❌azure-sdk-for-go - network/mgmt/2020-07-01/network - v56.3.0+ Field `ExtendedLocation` of struct `VirtualNetworkGatewayPropertiesFormat` has been removed + Field `VirtualNetworkExtendedLocationResourceID` of struct `VirtualNetworkGatewayPropertiesFormat` has been removed + Type of `SubnetPropertiesFormat.PrivateEndpointNetworkPolicies` has been changed from `*string` to `VirtualNetworkPrivateEndpointNetworkPolicies` + Type of `SubnetPropertiesFormat.PrivateLinkServiceNetworkPolicies` has been changed from `*string` to `VirtualNetworkPrivateLinkServiceNetworkPolicies`
️✔️azure-sdk-for-go - network/mgmt/2020-06-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2020-05-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2020-04-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2020-03-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2019-12-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2019-11-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2019-09-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2019-08-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2019-07-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2019-06-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2019-04-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2019-02-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2018-12-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2018-11-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2018-10-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2018-08-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2018-07-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2018-06-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2018-04-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2018-02-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2018-01-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2017-11-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2017-10-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2017-09-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2017-08-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2017-06-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2017-03-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2016-12-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2016-09-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2016-06-01/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2016-03-30/network - v56.3.0️✔️azure-sdk-for-go - network/mgmt/2015-06-15/network - v56.3.0️✔️azure-sdk-for-go - preview/network/mgmt/2015-05-01-preview/network - v56.3.0️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-5.0 command autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
️✔️Microsoft.Azure.Management.Network [View full logs] [Release SDK Changes]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️track2_azure-mgmt-network [View full logs] [Release SDK Changes]info [Changelog]
️⚠️ azure-sdk-for-java warning [Detail]
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] 2021-08-26 03:19:39 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-network-generated" cmderr [generate.py] 2021-08-26 03:19:39 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1" cmderr [generate.py] 2021-08-26 03:19:39 INFO autorest --version=3.4.5 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/network/azure-resourcemanager-network-generated --java.namespace=com.azure.resourcemanager.network.generated --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/network/resource-manager/readme.md cmderr [generate.py] 2021-08-26 03:22:18 INFO [CI][Success] Write to ci.yml cmderr [generate.py] 2021-08-26 03:22:18 INFO [POM][Process] dealing with pom.xml cmderr [generate.py] 2021-08-26 03:22:18 INFO [POM][Skip] pom already has module azure-resourcemanager-network-generated cmderr [generate.py] 2021-08-26 03:22:18 INFO [POM][Success] Write to pom.xml cmderr [generate.py] 2021-08-26 03:22:18 INFO [POM][Process] dealing with root pom cmderr [generate.py] 2021-08-26 03:22:18 INFO [POM][Success] Write to root pom
️✔️azure-resourcemanager-network-generated [View full logs] [Release SDK Changes]- pom.xml
- azure-resourcemanager-network-generated-1.0.0-beta.1-javadoc.jar
- azure-resourcemanager-network-generated-1.0.0-beta.1-sources.jar
- azure-resourcemanager-network-generated-1.0.0-beta.1.jar
cmderr [Inst] 2021-08-26 03:26:48 DEBUG Got artifact_id: azure-resourcemanager-network-generated cmderr [Inst] 2021-08-26 03:26:48 DEBUG Got artifact: pom.xml cmderr [Inst] 2021-08-26 03:26:48 DEBUG Got artifact: azure-resourcemanager-network-generated-1.0.0-beta.1-javadoc.jar cmderr [Inst] 2021-08-26 03:26:48 DEBUG Got artifact: azure-resourcemanager-network-generated-1.0.0-beta.1-sources.jar cmderr [Inst] 2021-08-26 03:26:48 DEBUG Got artifact: azure-resourcemanager-network-generated-1.0.0-beta.1.jar cmderr [Inst] 2021-08-26 03:26:48 DEBUG Match jar package: azure-resourcemanager-network-generated-1.0.0-beta.1.jar cmderr [Inst] 2021-08-26 03:26:48 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15709/azure-sdk-for-java/azure-resourcemanager-network-generated/azure-resourcemanager-network-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-network-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-network-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-network-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true ```"}
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️network/mgmt/2021-02-01/network [View full logs] [Release SDK Changes]info [Changelog] No exported changes
️✔️network/mgmt/2020-11-01/network [View full logs]info [Changelog] No exported changes
- Only show 4 items here, please refer to log for details.
️✔️network/mgmt/2020-08-01/network [View full logs] Breaking Change Detectedinfo [Changelog] - New field `ExtendedLocation` in struct `VirtualNetworkGateway` info [Changelog] info [Changelog] Total 2 breaking change(s), 35 additive change(s). info [Changelog]
- Only show 4 items here, please refer to log for details.
️✔️network/mgmt/2020-07-01/network [View full logs] Breaking Change Detectedinfo [Changelog] - New field `VNetExtendedLocationResourceID` in struct `VirtualNetworkGatewayPropertiesFormat` info [Changelog] info [Changelog] Total 2 breaking change(s), 27 additive change(s). info [Changelog]
️✔️network/mgmt/2020-06-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2020-05-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2020-04-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2020-03-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2019-12-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2019-11-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2019-09-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2019-08-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2019-07-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2019-06-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2019-04-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2019-02-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2018-12-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2018-11-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2018-10-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2018-08-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2018-07-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2018-06-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2018-04-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2018-02-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2018-01-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2017-11-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2017-10-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2017-09-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2017-08-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2017-06-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2017-03-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2016-12-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2016-09-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2016-06-01/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2016-03-30/network [View full logs]info [Changelog] No exported changes
️✔️network/mgmt/2015-06-15/network [View full logs]info [Changelog] No exported changes
️✔️preview/network/mgmt/2015-05-01-preview/network [View full logs]info [Changelog] No exported changes
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
warn Skip initScript due to not configured command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/network/resource-manager/readme.md
️✔️@azure/arm-network [View full logs] [Release SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/networkManagementClient.js → ./dist/arm-network.js... cmderr [npmPack] created ./dist/arm-network.js in 2.6s
️⚠️ azure-resource-manager-schemas warning [Detail]
command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json warn No file changes detected after generation warn Skip detect changed packages
|
Hi @MikhailTryakhov, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
@MikhailTryakhov, seems the PR contains unreviewed breaking change, could you help to follow the http://aka.ms/bcforapi to get it reviewed? |
|
Hi @MikhailTryakhov, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
@lirenhe looks like we're ready to merge it, please review it ASAP |
|
All lintdiff issues exist in the previous version so approved the lint diff issues. |
lirenhe
approved these changes
Aug 25, 2021
This was referenced Aug 26, 2021
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.