-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[Web PubSub] Add new API version for GA" #16310
Conversation
This reverts commit 39c7d63.
Hi, @vicancy Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/api/health' removed or restructured? Old: WebPubSub/stable/2021-10-01/webpubsub.json#L8:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/:generateToken' removed or restructured? Old: WebPubSub/stable/2021-10-01/webpubsub.json#L39:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/:closeConnections' removed or restructured? Old: WebPubSub/stable/2021-10-01/webpubsub.json#L115:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/:send' removed or restructured? Old: WebPubSub/stable/2021-10-01/webpubsub.json#L180:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/connections/{connectionId}' removed or restructured? Old: WebPubSub/stable/2021-10-01/webpubsub.json#L254:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/connections/{connectionId}/:send' removed or restructured? Old: WebPubSub/stable/2021-10-01/webpubsub.json#L375:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/groups/{group}' removed or restructured? Old: WebPubSub/stable/2021-10-01/webpubsub.json#L447:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/groups/{group}/:closeConnections' removed or restructured? Old: WebPubSub/stable/2021-10-01/webpubsub.json#L508:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/groups/{group}/:send' removed or restructured? Old: WebPubSub/stable/2021-10-01/webpubsub.json#L582:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/groups/{group}/connections/{connectionId}' removed or restructured? Old: WebPubSub/stable/2021-10-01/webpubsub.json#L665:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/users/{userId}' removed or restructured? Old: WebPubSub/stable/2021-10-01/webpubsub.json#L798:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/users/{userId}/:closeConnections' removed or restructured? Old: WebPubSub/stable/2021-10-01/webpubsub.json#L858:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/users/{userId}/:send' removed or restructured? Old: WebPubSub/stable/2021-10-01/webpubsub.json#L931:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/users/{userId}/groups/{group}' removed or restructured? Old: WebPubSub/stable/2021-10-01/webpubsub.json#L1003:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/users/{userId}/groups' removed or restructured? Old: WebPubSub/stable/2021-10-01/webpubsub.json#L1136:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/permissions/{permission}/connections/{connectionId}' removed or restructured? Old: WebPubSub/stable/2021-10-01/webpubsub.json#L1193:5 |
️️✔️
LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
Hi @vicancy, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Hi, @vicancy. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days. |
2 similar comments
Hi, @vicancy. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days. |
Hi, @vicancy. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days. |
Reverts #15907