Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Web PubSub] Add new API version for GA" #16310

Closed
wants to merge 1 commit into from

Conversation

vicancy
Copy link
Member

@vicancy vicancy commented Oct 8, 2021

Reverts #15907

@openapi-workflow-bot
Copy link

Hi, @vicancy Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 8, 2021

    Swagger Validation Report

    ️❌BreakingChange: 16 Errors, 0 Warnings failed [Detail]
    Rule Message
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/api/health' removed or restructured?
    Old: WebPubSub/stable/2021-10-01/webpubsub.json#L8:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/:generateToken' removed or restructured?
    Old: WebPubSub/stable/2021-10-01/webpubsub.json#L39:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/:closeConnections' removed or restructured?
    Old: WebPubSub/stable/2021-10-01/webpubsub.json#L115:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/:send' removed or restructured?
    Old: WebPubSub/stable/2021-10-01/webpubsub.json#L180:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/connections/{connectionId}' removed or restructured?
    Old: WebPubSub/stable/2021-10-01/webpubsub.json#L254:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/connections/{connectionId}/:send' removed or restructured?
    Old: WebPubSub/stable/2021-10-01/webpubsub.json#L375:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/groups/{group}' removed or restructured?
    Old: WebPubSub/stable/2021-10-01/webpubsub.json#L447:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/groups/{group}/:closeConnections' removed or restructured?
    Old: WebPubSub/stable/2021-10-01/webpubsub.json#L508:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/groups/{group}/:send' removed or restructured?
    Old: WebPubSub/stable/2021-10-01/webpubsub.json#L582:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/groups/{group}/connections/{connectionId}' removed or restructured?
    Old: WebPubSub/stable/2021-10-01/webpubsub.json#L665:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/users/{userId}' removed or restructured?
    Old: WebPubSub/stable/2021-10-01/webpubsub.json#L798:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/users/{userId}/:closeConnections' removed or restructured?
    Old: WebPubSub/stable/2021-10-01/webpubsub.json#L858:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/users/{userId}/:send' removed or restructured?
    Old: WebPubSub/stable/2021-10-01/webpubsub.json#L931:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/users/{userId}/groups/{group}' removed or restructured?
    Old: WebPubSub/stable/2021-10-01/webpubsub.json#L1003:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/users/{userId}/groups' removed or restructured?
    Old: WebPubSub/stable/2021-10-01/webpubsub.json#L1136:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/api/hubs/{hub}/permissions/{permission}/connections/{connectionId}' removed or restructured?
    Old: WebPubSub/stable/2021-10-01/webpubsub.json#L1193:5
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 8, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs] Generate from 778cf37064db15b064b0e6812b705f4c44c5fec9. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] opencensus-ext-azure 1.1.0 requires azure-core<2.0.0,>=1.12.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-messaging-webpubsubservice [View full logs]  [Preview SDK Changes]
      info	[Changelog] data-plan skip changelog generation temporarily
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 778cf37064db15b064b0e6812b705f4c44c5fec9. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/webpubsub/data-plane/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Azure.Messaging.WebPubSub [View full logs]  [Preview SDK Changes]
      warn	Skip artifact folder because it doesn't exist: artifacts/packages
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs] Generate from 778cf37064db15b064b0e6812b705f4c44c5fec9. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
      command	pwsh ./eng/scripts/Automation-Sdk-Generate.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      warn	No file changes detected after generation
      error	Fatal error: packageFolderFromFileSearch not configured and could not be found in legacy config
      packageFolderFromFileSearch not configured and could not be found in legacy config
      Error: packageFolderFromFileSearch not configured and could not be found in legacy config
          at workflowDetectChangedPackages (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:422:23)
          at workflowHandleReadmeMd (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:168:11)
          at async Object.exports.workflowMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:83:9)
          at async Object.exports.sdkAutoMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:152:13)
          at async /home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @vicancy, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @JackTn
    Copy link
    Member

    JackTn commented Jun 16, 2022

    Hi, @vicancy. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

    2 similar comments
    @JackTn
    Copy link
    Member

    JackTn commented Jun 16, 2022

    Hi, @vicancy. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

    @JackTn
    Copy link
    Member

    JackTn commented Jun 16, 2022

    Hi, @vicancy. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

    @vicancy vicancy deleted the revert-15907-vicancy-patch-1 branch June 16, 2022 03:48
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants