Added new Prometheus Rule Groups type #16613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @giladsu Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: autoResolved Location: Microsoft.AlertsManagement/preview/2021-07-22-preview/PrometheusRuleGroups.json#L528 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: common-types/resource-management/v3/types.json#L368 |
|
| 'PrometheusRule' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.AlertsManagement/preview/2021-07-22-preview/PrometheusRuleGroups.json#L474 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: ListResourcePrometheusRuleGroups Location: Microsoft.AlertsManagement/preview/2021-07-22-preview/PrometheusRuleGroups.json#L104 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/alertsmanagement/resource-manager/readme.md tag: specification/alertsmanagement/resource-manager/readme.md#tag-package-2019-06-preview |
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️Cross-Version Breaking Changes: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| "details":"Attention: There are some existing APIs currently documented in a new spec file. The validation may not be able to report breaking changes with these APIs. It is recommended not to rename swagger file or move public APIs to a new file when creating a new API version.The existing APIs being moved are:Operations_List;", "location":"https://github.com/Azure/azure-rest-api-specs/blob/bcb9c888914e9a3809ae87dd6868a8472bb6b20f/specification/alertsmanagement/resource-manager/Microsoft.AlertsManagement/preview/2021-07-22-preview/PrometheusRuleGroups.json" |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
Hi @giladsu, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Oct 31, 2021
|
Hi @giladsu Please follow the advice of |
Currently no - this is being onboarded to our generic alert rule control plane service. We have discussed moving this to RPaaS in the future (and PrometheusRuleGroups along with it of course), but do not have a concrete timeline. |
|
@mentat9 - thank you for your comments. I've addressed all of them except for one where I need some more details in order to answer. Please let me know if I can provide any more information. Thanks. |
@mentat9 - thanks. I've answered the last one. If there is something else I am missing or haven't answered, please let me know. |
Your comments indicate you have made updates, but you haven't pushed any changes. Also, there are still 4 unresolved comments. |
|
Currently no - this is being onboarded to our generic alert rule control plane service. We have discussed moving this to RPaaS in the future (and PrometheusRuleGroups along with it of course), but do not have a concrete timeline. In reply to: 958603876 |
mentat9
added
ARMSignedOff
|
@msyyc - can this be signed off by you to continue with the merge or are there other steps that need to be taken? |
|
Hi @giladsu, you need to ask for at least one approval from assigners before merge. Usually, assignee can't sign off the content. |
|
@mentat9 - I'm not sure why but the 2 "reviewers" listed are not part of the team and it doesnt seem possible to add additional reviewers. Can you sign off or advise on how to add another reviewer to the list? |
@giladsu, ARM reviewers aren't authorized to approve or merge PRs. We just review and approve changes to the REST layer. If your PR isn't getting traction, you can try email to SDK Release Owners ([email protected]) to get some help. |
msyyc
approved these changes
Nov 19, 2021
This was referenced Nov 19, 2021
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Nov 19, 2021
25 tasks
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
* Added new Prometheus Rule Groups type * Added list example * Added missing brackets * Added to readme * Fixed readme * Added delete example * Added get example * Added create example * Added patch example * Test * Fixes * Added missing brace * Added rule group name * Fixed * Pretier * Tool fix * Update readme * Another prettier fix * More * Added system data * Removed referenced file * Removed system data * Added location to patch * Added back systemdata * Fixed systemdata * Changes * Fixed issue * Added operations * CR fixes * Using common parameters * Last CR fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.